Skip to content

Reorg ppc64 pmu insn counting

Daniel Henrique Barboza qemu-devel 2 versions Applied

Status from this message: Applied in ppc-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyApplied
  2. v25 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Patch 1:
* fixed "PMC[1-5]" comment in target/ppc/cpu.h
- Former patch 4: squashed into patch 1
- Patch 4 (former 5):
* use boolean variables instead of uint32_t
* added Richard's r-b
- v2 link: https://lists.gnu.org/archive/html/qemu-devel/2022-01/msg00117.html

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4target/ppc: Cache per-pmc insn and cycle count settingstarget/ppc/cpu.h target/ppc/cpu_init.c target/ppc/helper_regs.c +3 more+58 -200 replies
2/4target/ppc: Rewrite pmu_increment_insnstarget/ppc/power8-pmu.c+49 -290 replies
3/4target/ppc: Use env->pnc_cyc_cnttarget/ppc/power8-pmu.c+9 -980 replies
4/4target/ppc: do not call hreg_compute_hflags() in helper_store_mmcr0()target/ppc/power8-pmu.c+6 -10 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchRichard Henderson
1/4
2/4
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] Reorg ppc64 pmu insn counting

Hi,

This new version implements Richard's suggestions made in the v2 review.

Changes from v2:
- Patch 1:
* fixed "PMC[1-5]" comment in target/ppc/cpu.h
- Former patch 4: squashed into patch 1
- Patch 4 (former 5):
* use boolean variables instead of uint32_t
* added Richard's r-b
- v2 link: https://lists.gnu.org/archive/html/qemu-devel/2022-01/msg00117.html

Daniel Henrique Barboza (1):
target/ppc: do not call hreg_compute_hflags() in helper_store_mmcr0()

Richard Henderson (3):
target/ppc: Cache per-pmc insn and cycle count settings target/ppc: Rewrite pmu_increment_insns target/ppc: Use env->pnc_cyc_cnt

 target/ppc/cpu.h         |   3 +
 target/ppc/cpu_init.c    |   1 +
 target/ppc/helper_regs.c |   2 +-
 target/ppc/machine.c     |   2 +
 target/ppc/power8-pmu.c  | 238 +++++++++++++++++----------------------
 target/ppc/power8-pmu.h  |  14 +--
 6 files changed, 117 insertions(+), 143 deletions(-)
Signature · 1 line
2.33.1