Skip to content

RFC Make MAC/PHY time stamping selectable

Richard Cochran lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 31 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net: ethtool: Refactor identical get_ts_info implementations.drivers/net/bonding/bond_main.c include/linux/ethtool.h net/8021q/vlan_dev.c +1 more+17 -263 replies
2/4net: Expose available time stamping layers to user space.Documentation/ABI/testing/sysfs-class-net-timestamping drivers/net/phy/phy_device.c include/linux/netdevice.h +1 more+89 -01 reply
3/4net: Let the active time stamping layer be selectable.Documentation/ABI/testing/sysfs-class-net-timestamping net/core/dev_ioctl.c net/core/net-sysfs.c +2 more+111 -1227 replies
4/4net: fix up drivers WRT phy time stampingdrivers/net/ethernet/freescale/fec_main.c drivers/net/ethernet/mscc/ocelot_net.c drivers/net/ethernet/ti/cpsw_priv.c +2 more+32 -540 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchVladimir Oltean
1/4R-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC V1 net-next 0/4] Make MAC/PHY time stamping selectable

Up until now, there was no way to let the user select the layer at which time stamping occurs. The stack assumed that PHY time stamping is always preferred, but some MAC/PHY combinations were buggy.

This series aims to allow the user to select the desired layer administratively.

- Patch 1 refactors get_ts_info copy/paste code.

- Patch 2 introduces sysfs files that reflect the current, static preference of PHY over MAC.

- Patch 3 makes the layer selectable at run time.

- Patch 4 fixes up MAC drivers that attempt to defer to the PHY layer. This patch is broken out for review, but it will eventually be squashed into Patch 3 after comments come in.

Thanks,
Richard

Richard Cochran (4):
net: ethtool: Refactor identical get_ts_info implementations.
net: Expose available time stamping layers to user space.
net: Let the active time stamping layer be selectable.
net: fix up drivers WRT phy time stamping

 .../ABI/testing/sysfs-class-net-timestamping  |  20 ++++
 drivers/net/bonding/bond_main.c               |  14 +--
 drivers/net/ethernet/freescale/fec_main.c     |  23 ++--
 drivers/net/ethernet/mscc/ocelot_net.c        |  21 ++--
 drivers/net/ethernet/ti/cpsw_priv.c           |  12 +--
 drivers/net/ethernet/ti/netcp_ethss.c         |  26 +----
 drivers/net/macvlan.c                         |   4 +-
 drivers/net/phy/phy_device.c                  |   2 +
 include/linux/ethtool.h                       |   8 ++
 include/linux/netdevice.h                     |  10 ++
 net/8021q/vlan_dev.c                          |  15 +--
 net/core/dev_ioctl.c                          |  44 +++++++-
 net/core/net-sysfs.c                          | 102 ++++++++++++++++++
 net/core/timestamping.c                       |   6 ++
 net/ethtool/common.c                          |  24 ++++-
 15 files changed, 244 insertions(+), 87 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-class-net-timestamping
Signature · 1 line
2.20.1