Skip to content

add generic vDPA device support

Longpeng(Mike) via qemu-devel 13 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest5 patches 5 repliesIn review
  2. v105 patches 5 repliesSuperseded
  3. v95 patches 1 replySuperseded
Earlier versions · 10
VersionPostedPatchesRepliesStatus
v85 patches7 repliesSuperseded
v7 posting 2/24 patches6 repliesSuperseded
v7 posting 1/24 patches0 repliesSuperseded
v6 posting 2/24 patches8 repliesSuperseded
v6 posting 1/24 patches0 repliesSuperseded
v54 patches6 repliesSuperseded
v44 patches7 repliesSuperseded
v310 patches6 repliesSuperseded
v210 patches17 repliesSuperseded
v1 RFC10 patches41 repliesSuperseded

Changes v11->v10 from the cover letter

- add requirements, optimize the preparation [Stefano]

Patches in v11 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5virtio: get class_id and pci device id by the virtio idhw/virtio/virtio-pci.c include/hw/virtio/virtio-pci.h+93 -00 replies
2/5vdpa: add vdpa-dev supporthw/virtio/Kconfig hw/virtio/meson.build hw/virtio/vdpa-dev.c +1 more+425 -00 replies
3/5vdpa: add vdpa-dev-pci supporthw/virtio/meson.build hw/virtio/vdpa-dev-pci.c+103 -00 replies
4/5vdpa-dev: mark the device as unmigratablehw/virtio/vdpa-dev.c+1 -00 replies
5/5docs: Add generic vhost-vdpa device documentationdocs/system/devices/vhost-vdpa-generic-device.rst+68 -05 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchStefano GarzarellaJason Wang
1/5A-b
2/5R-b A-b
3/5R-b A-b
4/5R-b A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v11 thread

Cover letter [PATCH v11 0/5] add generic vDPA device support

From: Longpeng <[email protected]>

Hi guys,

With the generic vDPA device, QEMU won't need to touch the device types any more, such like vfio.

We can use the generic vDPA device as follow:
-device vhost-vdpa-device-pci,vhostdev=/dev/vhost-vdpa-X Or
-M microvm -m 512m -smp 2 -kernel ... -initrd ... -device \
vhost-vdpa-device,vhostdev=/dev/vhost-vdpa-x

Changes v11->v10:
- add requirements, optimize the preparation [Stefano]

Changes v10 -> v9:
- optimize the doc [Jason]

Changes v9 -> v8:
- rename vhost-vdpa-device.rst to vhost-vdpa-generic-device.rst [Jason, Stefano]
- emphasize the vhost-vDPA generic device in doc [Jason]

Changes v8 -> v7:
- add migration blocker. [Michael]

Changes v6 -> v7:
(v6: https://mail.gnu.org/archive/html/qemu-devel/2022-05/msg02821.html)
- rebase. [Jason]
- add documentation . [Stefan]

Changes v5 -> v6:
Patch 2:
- Turn to the original approach in the RFC to initialize the virtio_pci_id_info array. [Michael]
https://lore.kernel.org/all/[email protected]/
Patch 3:
- Fix logical error of exception handler around the post_init. [Stefano]
- Fix some coding style warnings. [Stefano]
Patch 4:
- Fix some coding style warnings. [Stefano]

Changes v4 -> v5:
Patch 3:
- remove vhostfd [Jason]
- support virtio-mmio [Jason]

Changes v3 -> v4:
v3: https://www.mail-archive.com/[email protected]/msg877015.html
- reorganize the series [Stefano]
- fix some typos [Stefano]
- fix logical error in vhost_vdpa_device_realize [Stefano]

Changes v2 -> v3
Patch 4 & 5:
- only call vdpa ioctls in vdpa-dev.c [Stefano, Longpeng]
- s/VQS_NUM/VQS_COUNT [Stefano]
- check both vdpa_dev_fd and vdpa_dev [Stefano]
Patch 6:
- move all steps into vhost_vdpa_device_unrealize. [Stefano]

Changes RFC -> v2
Patch 1:
- rename 'pdev_id' to 'trans_devid' [Michael]
- only use transitional device id for the devices listed in the spec [Michael]
- use macros to make the id_info table clearer [Longpeng]
- add some modern devices in the id_info table [Longpeng]
Patch 2:
- remove the GET_VECTORS_NUM command [Jason]
Patch 4:
- expose vdpa_dev_fd as a QOM preperty [Stefan]
- introduce vhost_vdpa_device_get_u32 as a common function to make the code clearer [Stefan]
- fix the misleading description of 'dc->desc' [Stefano]
Patch 5:
- check returned number of virtqueues [Stefan]
Patch 6:
- init s->num_queues [Stefano]
- free s->dev.vqs [Stefano]

Longpeng (Mike) (5):
virtio: get class_id and pci device id by the virtio id
vdpa: add vdpa-dev support
vdpa: add vdpa-dev-pci support
vdpa-dev: mark the device as unmigratable
docs: Add generic vhost-vdpa device documentation

 .../devices/vhost-vdpa-generic-device.rst     |  68 ++++
 hw/virtio/Kconfig                             |   5 +
 hw/virtio/meson.build                         |   2 +
 hw/virtio/vdpa-dev-pci.c                      | 102 +++++
 hw/virtio/vdpa-dev.c                          | 377 ++++++++++++++++++
 hw/virtio/virtio-pci.c                        |  88 ++++
 include/hw/virtio/vdpa-dev.h                  |  43 ++
 include/hw/virtio/virtio-pci.h                |   5 +
 8 files changed, 690 insertions(+)
 create mode 100644 docs/system/devices/vhost-vdpa-generic-device.rst
 create mode 100644 hw/virtio/vdpa-dev-pci.c
 create mode 100644 hw/virtio/vdpa-dev.c
 create mode 100644 include/hw/virtio/vdpa-dev.h
Signature · 1 line
2.23.0