Skip to content

btrfs: reuse existing pointers from btrfs_ioctl

Sahil Kang linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1btrfs: reuse existing pointers from btrfs_ioctlfs/btrfs/ioctl.c+11 -174 replies
1/1btrfs: reuse existing inode from btrfs_ioctlfs/btrfs/ioctl.c fs/btrfs/send.c fs/btrfs/send.h+21 -281 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchQu Wenruo
1/1R-b
1/1R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/1] btrfs: reuse existing pointers from btrfs_ioctl

This is a small cleanup that reuses some of the existing pointers and removes the duplicated dereferencing.

There are other subfunctions that have similar/identical dereferencing as the enclosing btrfs_ioctl, but I'm not sure if changing those is welcomed since it would require changing their arg count. Right now, all of the sub ioctl functions have essentially the same signature.

For example, reusing the pointers for btrfs_ioctl_set_fslabel would require passing in *fs_info and *root, in addition to its current args.

Sahil Kang (1):
btrfs: reuse existing pointers from btrfs_ioctl

 fs/btrfs/ioctl.c | 28 +++++++++++-----------------
 1 file changed, 11 insertions(+), 17 deletions(-)
Signature · 1 line
Sahil