Skip to content

Add low power hibernation support to cs35l41

Charles Keepax alsa-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8ASoC: cs35l41: Add cs35l51/53 IDssound/soc/codecs/cs35l41-i2c.c sound/soc/codecs/cs35l41-spi.c+4 -00 replies
2/8ASoC: cs35l41: Remove incorrect commentsound/soc/codecs/cs35l41.c+0 -20 replies
3/8ASoC: cs35l41: Correct DSP power downsound/soc/codecs/cs35l41.c+8 -40 replies
4/8ASoC: cs35l41: Correct handling of some registers in the cachesound/soc/codecs/cs35l41-lib.c+22 -590 replies
5/8firmware: cs_dsp: Clear core reset for cachedrivers/firmware/cirrus/cs_dsp.c+10 -40 replies
6/8ASoC: wm_adsp: Add support for "toggle" preloaderssound/soc/codecs/wm_adsp.c sound/soc/codecs/wm_adsp.h+19 -30 replies
7/8ASoC: cs35l41: Update handling of test key registersinclude/sound/cs35l41.h sound/soc/codecs/cs35l41-lib.c sound/soc/codecs/cs35l41.c+52 -470 replies
8/8ASoC: cs35l41: Add support for hibernate memory retention modeinclude/sound/cs35l41.h sound/soc/codecs/cs35l41-i2c.c sound/soc/codecs/cs35l41-lib.c +3 more+213 -40 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by.

PatchDavid Rhodes
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8Co-authored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] Add low power hibernation support to cs35l41

This patch series adds support for the low power hibernation feature on cs35l41. This allows the DSP memory to be retained whilst the device enters a very low power state.

Patches 1-6 can happily be applied straight away and are mostly bug fixes to set things up for the series specifically around getting the cache handling corrected in the driver.

Patches 7,8 specifically will cause some very minor conflicts with Lucas's currently outstanding work on the HDA version of cs35l41. Whilst things will still build, this patch adds a test key function his code will now have to call. If his patches are getting merged first I will respin this series to update his code, he is currently on holiday until the 12th of Jan, so if we want to wait for another spin of those patches I can work with him to update them at that time. Or alternatively we could just merge them all and I will do a quick fixup patch at the end, since there is no build breakage.

Thanks,
Charles

Charles Keepax (7):
ASoC: cs35l41: Remove incorrect comment
ASoC: cs35l41: Correct DSP power down
ASoC: cs35l41: Correct handling of some registers in the cache
ASoC: cs35l41: Update handling of test key registers
firmware: cs_dsp: Clear core reset for cache
ASoC: wm_adsp: Add support for "toggle" preloaders
ASoC: cs35l41: Add support for hibernate memory retention mode

David Rhodes (1):
ASoC: cs35l41: Add cs35l51/53 IDs

 drivers/firmware/cirrus/cs_dsp.c |  14 ++-
 include/sound/cs35l41.h          |   7 ++
 sound/soc/codecs/cs35l41-i2c.c   |   3 +
 sound/soc/codecs/cs35l41-lib.c   | 152 ++++++++++--------------
 sound/soc/codecs/cs35l41-spi.c   |   3 +
 sound/soc/codecs/cs35l41.c       | 246 +++++++++++++++++++++++++++++++++++----
 sound/soc/codecs/cs35l41.h       |   4 +
 sound/soc/codecs/wm_adsp.c       |  14 ++-
 sound/soc/codecs/wm_adsp.h       |   8 ++
 9 files changed, 328 insertions(+), 123 deletions(-)
Signature · 27 lines
2.11.0

Charles Keepax (7):
  ASoC: cs35l41: Remove incorrect comment
  ASoC: cs35l41: Correct DSP power down
  ASoC: cs35l41: Correct handling of some registers in the cache
  firmware: cs_dsp: Clear core reset for cache
  ASoC: wm_adsp: Add support for "toggle" preloaders
  ASoC: cs35l41: Update handling of test key registers
  ASoC: cs35l41: Add support for hibernate memory retention mode

David Rhodes (1):
  ASoC: cs35l41: Add cs35l51/53 IDs

 drivers/firmware/cirrus/cs_dsp.c |  14 ++-
 include/sound/cs35l41.h          |   7 ++
 sound/soc/codecs/cs35l41-i2c.c   |   3 +
 sound/soc/codecs/cs35l41-lib.c   | 152 ++++++++++--------------
 sound/soc/codecs/cs35l41-spi.c   |   3 +
 sound/soc/codecs/cs35l41.c       | 246 +++++++++++++++++++++++++++++++++++----
 sound/soc/codecs/cs35l41.h       |   4 +
 sound/soc/codecs/wm_adsp.c       |  14 ++-
 sound/soc/codecs/wm_adsp.h       |   8 ++
 9 files changed, 328 insertions(+), 123 deletions(-)

-- 
2.11.0