Skip to content

Fix -device JSON support wrt hotplug

Daniel P. Berrangé qemu-devel 1 version Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 10 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/1softmmu: fix device deletion events with -device JSON syntaxqapi/qdev.json softmmu/vl.c tests/qtest/device-plug-test.c+26 -29 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchThomas HuthJán TomkoLaurent VivierMarkus Armbruster
1/1R-b T-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/1] Fix -device JSON support wrt hotplug

Libvirt switched to using -device JSON support, but we discovered in testing that it is broken for hotplug, never sending DEVICE_DELETED events. This is caused by a subtle refcount leak.

Daniel P. Berrangé (1):
softmmu: fix device deletion events with -device JSON syntax

 qapi/qdev.json                 |  5 ++++-
 softmmu/vl.c                   |  4 +++-
 tests/qtest/device-plug-test.c | 19 +++++++++++++++++++
 3 files changed, 26 insertions(+), 2 deletions(-)
Signature · 1 line
2.33.1