Skip to content

git-p4: Rationalise command construction

Joel Holdsworth git 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3git-p4: don't select shell mode using the type of the command argumentgit-p4.py+63 -630 replies
2/3git-p4: pass command arguments as lists instead of using shellgit-p4.py+43 -620 replies
3/3git-p4: don't print shell commands as python listsgit-p4.py+9 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] git-p4: Rationalise command construction

This patch-set removes the mixing of commands constructed using strings with commands constructed using python lists. The goal being to simplify the code by standardising on the usage of lists throughout the script.

It also attempts to make usage of shell execution clearer by changing the code to require the caller to explicitly request execution-in-shell if required.

With the script changed over to using lists every, there is also a patch to improve the printing of log messages as command strings rather than as stringified python lists

This version of the patch-set adds a missing signoff, and corrects a typo in a commit message.

Joel Holdsworth (3):
git-p4: don't select shell mode using the type of the command argument
git-p4: pass command arguments as lists instead of using shell
git-p4: don't print shell commands as python lists

 git-p4.py | 176 ++++++++++++++++++++++++------------------------------
 1 file changed, 79 insertions(+), 97 deletions(-)
Signature · 1 line
2.34.1