Skip to content

queue_rqs error handling

Keith Busch linux-block linux-nvme 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest4 patches 4 repliesApplied

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4block: move rq_list macros to blk-mq.hfs/io_uring.c include/linux/blk-mq.h include/linux/blkdev.h+30 -301 reply
2/4block: introduce rq_list_for_each_safe macroinclude/linux/blk-mq.h+4 -00 replies
3/4block: introduce rq_list_moveinclude/linux/blk-mq.h+17 -01 reply
4/4nvme-pci: fix queue_rqs list splittingdrivers/nvme/host/pci.c+14 -141 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCHv3 0/4] queue_rqs error handling

The only real change since v2 is a prep patch that relocates the rq list macros to blk-mq.h since that's where 'struct request' is defined.

Patch 3 removes the 'next' parameter since it is trivially obtainable via 'rq->rq_next' anyway.

Otherwise, the series is the same as v2 and tested with lots of random error injection in the prep path. The same errors would have lost requests in the current driver, but is successful with this series.

Keith Busch (4):
block: move rq_list macros to blk-mq.h
block: introduce rq_list_for_each_safe macro
block: introduce rq_list_move
nvme-pci: fix queue_rqs list splitting

 drivers/nvme/host/pci.c | 28 +++++++++++------------
 fs/io_uring.c           |  2 +-
 include/linux/blk-mq.h  | 50 +++++++++++++++++++++++++++++++++++++++++
 include/linux/blkdev.h  | 29 ------------------------
 4 files changed, 65 insertions(+), 44 deletions(-)
Signature · 1 line
2.25.4