Skip to content

On AMD platforms only offer s2idle w/ proper FW

Mario Limonciello linux-acpi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3PM: suspend: Move some structure declarations arounddrivers/acpi/x86/s2idle.c kernel/power/suspend.c+17 -170 replies
2/3PM: sleep: Don't always assume s2idle will be enableddrivers/acpi/sleep.c drivers/acpi/x86/s2idle.c include/linux/suspend.h +1 more+27 -130 replies
3/3acpi: sleep: Don't offer s2idle on AMD platforms without LPS0drivers/acpi/x86/s2idle.c+10 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchBasavaraj Natikar
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] On AMD platforms only offer s2idle w/ proper FW

Currently the Linux kernel will offer s2idle regardless of whether the FADT indicates the system should use or on X86 if the LPS0 ACPI device has been activated.

On some non-AMD platforms s2idle can be offered even without proper firmware support. The power consumption may be higher in these instances but the system otherwise properly suspends and resumes.

On AMD platforms however when the FW has been configured not to offer s2idle some different hardware initialization has occurred such that the system won't properly resume.

This patch series changes the kernel suspend code to conditionally decide whether to offer s2idle. When an AMD system is encountered all the prerequisites will be checked before s2idle is offered to the user.

Mario Limonciello (3):
PM: suspend: Move some structure declarations around
PM: sleep: Don't always assume s2idle will be enabled
acpi: sleep: Don't offer s2idle on AMD platforms without LPS0

 drivers/acpi/sleep.c      |  6 ++++++
 drivers/acpi/x86/s2idle.c | 36 ++++++++++++++++++++++++----------
 include/linux/suspend.h   |  1 +
 kernel/power/suspend.c    | 41 ++++++++++++++++++++-------------------
 4 files changed, 54 insertions(+), 30 deletions(-)
Signature · 1 line
2.25.1