Skip to content

ASoC: Xilinx fixes

Robert Hancock alsa-devel linux-devicetree 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 4 repliesIn review
  2. v26 patches 7 repliesSuperseded
  3. v15 patches 9 repliesSuperseded

Changes in v3 from the cover letter

-drop patches already merged
-added constraint to simple-card to allow enforcing valid sample rates

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ASoC: xilinx: xlnx_formatter_pcm: Handle sysclk settingsound/soc/xilinx/xlnx_formatter_pcm.c+25 -00 replies
2/6ASoC: xilinx: xlnx_i2s: create drvdata structuresound/soc/xilinx/xlnx_i2s.c+35 -312 replies
3/6ASoC: xilinx: xlnx_i2s: Handle sysclk settingsound/soc/xilinx/xlnx_i2s.c+81 -100 replies
4/6ASoC: simple-card-utils: Set sysclk on all componentssound/soc/generic/simple-card-utils.c+15 -01 reply
5/6ASoC: dt-bindings: simple-card: document new system-clock-fixed flagDocumentation/devicetree/bindings/sound/simple-card.yaml+11 -00 replies
6/6ASoC: simple-card-utils: Add new system-clock-fixed flaginclude/sound/simple_card_utils.h sound/soc/generic/simple-card-utils.c+61 -110 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchKuninori Morimoto
1/6
2/6
3/6
4/6R-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] ASoC: Xilinx fixes

There are drivers in mainline for the Xilinx Audio Formatter and Xilinx I2S IP cores. However, because of a few issues, these were only really usable with Xilinx's xlnx_pl_snd_card top-level driver, which is not in mainline (and not suitable for mainline).

The fixes in this patchset, for the simple-card layer as well as the Xilinx drivers, now allow these drivers to be properly used with simple-card without any out-of-tree support code.

Changes since v2:
-drop patches already merged
-added constraint to simple-card to allow enforcing valid sample rates

Changes since v1:
-formatting fixes
-renamed last_sysclk variables to sysclk
-require exact match for clock divisor rather than rounding to nearest -broke out driver data structure change in xlnx_i2s to separate patch -added constraints for sample rate based on sysclk to xlnx_i2s -switched to separate function for DAI parsing for platforms in simple_card

Robert Hancock (6):
ASoC: xilinx: xlnx_formatter_pcm: Handle sysclk setting
ASoC: xilinx: xlnx_i2s: create drvdata structure
ASoC: xilinx: xlnx_i2s: Handle sysclk setting
ASoC: simple-card-utils: Set sysclk on all components
ASoC: dt-bindings: simple-card: document new system-clock-fixed flag
ASoC: simple-card-utils: Add new system-clock-fixed flag

 .../bindings/sound/simple-card.yaml           |  11 ++
 include/sound/simple_card_utils.h             |   1 +
 sound/soc/generic/simple-card-utils.c         |  86 ++++++++--
 sound/soc/xilinx/xlnx_formatter_pcm.c         |  25 +++
 sound/soc/xilinx/xlnx_i2s.c                   | 147 +++++++++++++-----
 5 files changed, 223 insertions(+), 47 deletions(-)
Signature · 1 line
2.31.1