drm/msm: rework MDSS drivers
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest6 patches 0 repliesNew
- v46 patches 1 replySuperseded
- v3 posting 2/26 patches 3 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 posting 1/2 | 5 patches | 15 replies | Superseded | |
| v2 | 4 patches | 6 replies | Superseded | |
| v1 | 4 patches | 0 replies | Superseded |
Changes in v5 from the cover letter
- Fixed the issue with MODULE_DEVICE_TABLE reported by robot
- Fixed the comments accoring to suggestions of Stephen
- Removed extra goto (Stephen's suggestion)
- Break long kms->dev->dev->parent chains into cleaner dpu_dev/mdp_dev and mdss_dev to document device tree bindings. Add related comments. (Stephen's suggestion)
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | drm/msm: unify MDSS driversdrivers/ drivers/ drivers/ +2 more | +93 | 0 replies | |
| 2/6 | drm/msm: remove extra indirection for msm_mdssdrivers/ drivers/ drivers/ | +83 | 0 replies | |
| 3/6 | drm/msm: split the main platform driverdrivers/ drivers/ drivers/ +2 more | +288 | 0 replies | |
| 4/6 | drm/msm: stop using device's match data pointerdrivers/ drivers/ drivers/ +4 more | +42 | 0 replies | |
| 5/6 | drm/msm: allow compile time selection of driver componentsdrivers/ drivers/ drivers/ +3 more | +115 | 0 replies | |
| 6/6 | drm/msm: make mdp5/dpu devices master componentsdrivers/ drivers/ drivers/ +4 more | +79 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Abhinav Kumar | Stephen Boyd |
|---|---|---|
| 1/6 | R-b | R-b |
| 2/6 | R-b | R-b |
| 3/6 | R-b | R-b |
| 4/6 | R-b | R-b |
| 5/6 | R-b | |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/6] drm/msm: rework MDSS drivers
These patches coninue work started by AngeloGioacchino Del Regno in the previous cycle by further decoupling and dissecting MDSS and MDP drivers probe/binding paths.
This removes code duplication between MDP5 and DPU1 MDSS drivers, by merging them and moving to the top level.
Changes since v5:
- Fixed the issue with HW_REV access on MDP5 platforms
- Moved "mdss"/"mdss_phys" distinction from second patch to the first one
Changes since v4:
- Fixed the issue with MODULE_DEVICE_TABLE reported by robot
- Fixed the comments accoring to suggestions of Stephen
- Removed extra goto (Stephen's suggestion)
- Break long kms->dev->dev->parent chains into cleaner dpu_dev/mdp_dev and mdss_dev to document device tree bindings. Add related comments. (Stephen's suggestion)
Changes since v3:
- Rebased on top of current msm/msm-next
- Fixed issue with enabling/disabling MDP4/MDP5 vs DSI driver (per Stephen's suggestion)
- Reworked mdss_probe to remove extra platform_set_drvdata calls (per Stephen's suggestion)
- Fixed a typo in the Kconfig (noted by Rob)
- Added a patch to move component mastership from mdss to mdp5/dpu1 devices
Changes since v2:
- Rebased on top of current msm/msm-next(-staging)
- Allow disabling MDP4/MDP5/DPU/HDMI components (like we do for DP and DSI)
- Made mdp5_mdss_parse_clock() static
- Changed mdp5 to is_mdp5 argument in several functions
- Dropped boolean device data from the mdss driver
- Reworked error handling in msm_pdev_probe()
- Removed unused header inclusion
- Dropped __init/__exit from function prototypes
Changes since v1:
- Rebased on top of [2] and [1]
[1] https://patchwork.freedesktop.org/series/99066/
[2] https://patchwork.freedesktop.org/series/98521/
Dmitry Baryshkov (6):
drm/msm: unify MDSS drivers
drm/msm: remove extra indirection for msm_mdss drm/msm: split the main platform driver
drm/msm: stop using device's match data pointer drm/msm: allow compile time selection of driver components drm/msm: make mdp5/dpu devices master components
drivers/gpu/drm/msm/Kconfig | 50 ++- drivers/gpu/drm/msm/Makefile | 25 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 86 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 260 ------------ .../gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c | 3 + drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 54 ++- .../gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c | 3 + drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 57 ++- drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c | 252 ------------ drivers/gpu/drm/msm/msm_drv.c | 261 ++---------- drivers/gpu/drm/msm/msm_drv.h | 61 ++- drivers/gpu/drm/msm/msm_kms.h | 21 - drivers/gpu/drm/msm/msm_mdss.c | 384 ++++++++++++++++++ 13 files changed, 661 insertions(+), 856 deletions(-) delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c delete mode 100644 drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c create mode 100644 drivers/gpu/drm/msm/msm_mdss.c
Signature · 1 line
2.35.1