Skip to content

*** Fix reformat_objdump.awk ***

Samuel Zeter lkml llvm 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 1 replyIn review
  2. v2 posting 1/22 patches 1 replySuperseded
  3. v12 patches 4 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2arch/x86/tools/objdump_reformat.awk: Ensure regex matches fwaitarch/x86/tools/objdump_reformat.awk+1 -10 replies
2/2arch/x86/tools/objdump_reformat.awk: Allow for spacesarch/x86/tools/objdump_reformat.awk+1 -10 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMasami HiramatsuNathan ChancellorKees Cook
SeriesA-b R-b T-b
1/2A-b T-b
2/2A-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [RESEND PATCH v2 0/2] *** Fix reformat_objdump.awk ***

These are two small patches which originally dealt with the problem found at:

https://github.com/ClangBuiltLinux/linux/issues/1364

The original steps to reproduce were:

$ make -skj"$(nproc)" LLVM=1 LLVM_IAS=1 defconfig
$ scripts/config -e X86_DECODER_SELFTEST
$ make -skj"$(nproc)" LLVM=1 LLVM_IAS=1 olddefconfig bzImage

Which resulted in the error:
arch/x86/tools/insn_decoder_test: warning: objdump says 0 bytes, but insn_get_length() says 2

Upon inspection it turned out llvm-objdump was formatting its output differently, which caused objdump_reformat.awk to incorrectly output its values.

After fixing that bug, a second one was seen where the instruction "wait" was incorrectly matched with "fwait", which again caused insn_decoder_test to fail.

Samuel Zeter (2):
arch/x86/tools/objdump_reformat.awk: Ensure regex matches fwait arch/x86/tools/objdump_reformat.awk: Allow for spaces

 arch/x86/tools/objdump_reformat.awk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

base-commit: 151297128990b4b44be8d70b983053831fa857f6

Signature · 1 line
2.38.1