Start cleaning up register definitions
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest11 patches 13 repliesIn review
- v27 patches 8 repliesSuperseded
- v11 patch 6 repliesSuperseded
Changes in v3 from the cover letter
- Split out i915_reg_defs.h in its own patch
- Also split out combo PHY and MG/DKL PHY sets of registers
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | drm/i915: Use parameterized GPR register definitions everywheredrivers/ drivers/ | +36 | 0 replies | |
| 2/11 | drm/i915: Parameterize PWRCTX_MAXCNTdrivers/ drivers/ | +5 | 0 replies | |
| 3/11 | drm/i915: Parameterize ECOSKPDdrivers/ drivers/ drivers/ +1 more | +13 | 3 replies | |
| 4/11 | drm/i915: Use RING_PSMI_CTL rather than per-engine macrosdrivers/ drivers/ drivers/ +1 more | +15 | 0 replies | |
| 5/11 | drm/i915: Replace GFX_MODE_GEN7 with RING_MODE_GEN7drivers/ drivers/ drivers/ | +3 | 0 replies | |
| 6/11 | drm/i915: Introduce i915_reg_defs.hdrivers/ drivers/ | +99 | 1 reply | |
| 7/11 | drm/i915/gt: Move engine registers to their own headerdrivers/ drivers/ drivers/ +28 more | +228 | 1 reply | |
| 8/11 | drm/i915: Move SNPS PHY registers to their own headerdrivers/ drivers/ drivers/ | +76 | 0 replies | |
| 9/11 | drm/i915: Move combo PHY registers to their own headerdrivers/ drivers/ drivers/ +4 more | +167 | 1 reply | |
| 10/11 | drm/i915: Move TC PHY registers to their own headerdrivers/ drivers/ drivers/ +2 more | +347 | 1 reply | |
| 11/11 | drm/i915: Drop unused _PORT3 and _PORT4 TC phy register offsetsdrivers/ | +0 | 1 reply |
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Jani Nikula | Lucas De Marchi |
|---|---|---|
| 1/11 | R-b | |
| 2/11 | R-b | |
| 3/11 | R-b | |
| 4/11 | R-b | |
| 5/11 | R-b | |
| 6/11 | R-b | |
| 7/11 | R-b | |
| 8/11 | R-b | |
| 9/11 | R-b | |
| 10/11 | R-b | |
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Intel-gfx] [PATCH v3 00/11] Start cleaning up register definitions
Let's start splitting up and cleaning up parts of i915_reg.h. Rather than starting with dead code removal as we did in v1, this time we'll switch a few macros to parameterized style, and then move a few types of registers (engine registers, SNPS PHY registers) off to their own header files.
v3:
- Split out i915_reg_defs.h in its own patch
- Also split out combo PHY and MG/DKL PHY sets of registers
Matt Roper (11):
drm/i915: Use parameterized GPR register definitions everywhere drm/i915: Parameterize PWRCTX_MAXCNT
drm/i915: Parameterize ECOSKPD
drm/i915: Use RING_PSMI_CTL rather than per-engine macros drm/i915: Replace GFX_MODE_GEN7 with RING_MODE_GEN7 drm/i915: Introduce i915_reg_defs.h
drm/i915/gt: Move engine registers to their own header drm/i915: Move SNPS PHY registers to their own header drm/i915: Move combo PHY registers to their own header drm/i915: Move TC PHY registers to their own header drm/i915: Drop unused _PORT3 and _PORT4 TC phy register offsets
drivers/gpu/drm/i915/display/icl_dsi.c | 1 + .../gpu/drm/i915/display/intel_combo_phy.c | 1 + .../drm/i915/display/intel_combo_phy_regs.h | 162 ++++ drivers/gpu/drm/i915/display/intel_ddi.c | 2 + .../drm/i915/display/intel_display_power.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 1 + drivers/gpu/drm/i915/display/intel_snps_phy.c | 1 + .../drm/i915/display/intel_snps_phy_regs.h | 75 ++ drivers/gpu/drm/i915/display/intel_tc.c | 1 + .../gpu/drm/i915/display/intel_tc_phy_regs.h | 280 ++++++ drivers/gpu/drm/i915/gt/gen2_engine_cs.c | 1 + drivers/gpu/drm/i915/gt/gen6_engine_cs.c | 1 + drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 1 + drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 + drivers/gpu/drm/i915/gt/intel_engine_regs.h | 197 ++++ .../drm/i915/gt/intel_execlists_submission.c | 1 + drivers/gpu/drm/i915/gt/intel_gt.c | 1 + drivers/gpu/drm/i915/gt/intel_lrc.c | 1 + drivers/gpu/drm/i915/gt/intel_lrc_reg.h | 15 - drivers/gpu/drm/i915/gt/intel_rc6.c | 9 +- drivers/gpu/drm/i915/gt/intel_reset.c | 1 + drivers/gpu/drm/i915/gt/intel_ring.c | 1 + .../gpu/drm/i915/gt/intel_ring_submission.c | 11 +- drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 +- drivers/gpu/drm/i915/gt/selftest_engine_pm.c | 1 + drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 1 + drivers/gpu/drm/i915/gt/selftest_rps.c | 1 + drivers/gpu/drm/i915/gt/selftest_timeline.c | 1 + drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 1 + .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 3 +- drivers/gpu/drm/i915/gvt/cmd_parser.c | 1 + drivers/gpu/drm/i915/gvt/handlers.c | 4 +- drivers/gpu/drm/i915/gvt/mmio_context.c | 5 +- drivers/gpu/drm/i915/gvt/mmio_context.h | 1 + drivers/gpu/drm/i915/i915_cmd_parser.c | 69 +- drivers/gpu/drm/i915/i915_gpu_error.c | 1 + drivers/gpu/drm/i915/i915_perf.c | 1 + drivers/gpu/drm/i915/i915_pmu.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 841 +----------------- drivers/gpu/drm/i915/i915_reg_defs.h | 98 ++ drivers/gpu/drm/i915/i915_request.c | 1 + drivers/gpu/drm/i915/intel_pm.c | 11 +- drivers/gpu/drm/i915/intel_uncore.c | 2 +- 44 files changed, 911 insertions(+), 907 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_combo_phy_regs.h create mode 100644 drivers/gpu/drm/i915/display/intel_snps_phy_regs.h create mode 100644 drivers/gpu/drm/i915/display/intel_tc_phy_regs.h create mode 100644 drivers/gpu/drm/i915/gt/intel_engine_regs.h create mode 100644 drivers/gpu/drm/i915/i915_reg_defs.h
Signature · 1 line
2.34.1