Skip to content

Start cleaning up register definitions

Matt Roper intel-gfx 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 13 repliesIn review
  2. v27 patches 8 repliesSuperseded
  3. v11 patch 6 repliesSuperseded

Changes in v3 from the cover letter

- Split out i915_reg_defs.h in its own patch
- Also split out combo PHY and MG/DKL PHY sets of registers

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/i915: Use parameterized GPR register definitions everywheredrivers/gpu/drm/i915/i915_cmd_parser.c drivers/gpu/drm/i915/i915_reg.h+36 -400 replies
2/11drm/i915: Parameterize PWRCTX_MAXCNTdrivers/gpu/drm/i915/gt/intel_rc6.c drivers/gpu/drm/i915/i915_reg.h+5 -90 replies
3/11drm/i915: Parameterize ECOSKPDdrivers/gpu/drm/i915/gt/intel_workarounds.c drivers/gpu/drm/i915/gvt/handlers.c drivers/gpu/drm/i915/i915_reg.h +1 more+13 -133 replies
4/11drm/i915: Use RING_PSMI_CTL rather than per-engine macrosdrivers/gpu/drm/i915/gt/intel_ring_submission.c drivers/gpu/drm/i915/gt/intel_workarounds.c drivers/gpu/drm/i915/i915_reg.h +1 more+15 -200 replies
5/11drm/i915: Replace GFX_MODE_GEN7 with RING_MODE_GEN7drivers/gpu/drm/i915/gt/intel_workarounds.c drivers/gpu/drm/i915/gvt/mmio_context.c drivers/gpu/drm/i915/i915_reg.h+3 -40 replies
6/11drm/i915: Introduce i915_reg_defs.hdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/i915_reg_defs.h+99 -871 reply
7/11drm/i915/gt: Move engine registers to their own headerdrivers/gpu/drm/i915/gt/gen2_engine_cs.c drivers/gpu/drm/i915/gt/gen6_engine_cs.c drivers/gpu/drm/i915/gt/gen6_ppgtt.c +28 more+228 -1941 reply
8/11drm/i915: Move SNPS PHY registers to their own headerdrivers/gpu/drm/i915/display/intel_snps_phy.c drivers/gpu/drm/i915/display/intel_snps_phy_regs.h drivers/gpu/drm/i915/i915_reg.h+76 -670 replies
9/11drm/i915: Move combo PHY registers to their own headerdrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_combo_phy.c drivers/gpu/drm/i915/display/intel_combo_phy_regs.h +4 more+167 -1541 reply
10/11drm/i915: Move TC PHY registers to their own headerdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_dpll_mgr.c drivers/gpu/drm/i915/display/intel_tc.c +2 more+347 -3331 reply
11/11drm/i915: Drop unused _PORT3 and _PORT4 TC phy register offsetsdrivers/gpu/drm/i915/display/intel_tc_phy_regs.h+0 -641 reply

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchJani NikulaLucas De Marchi
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Intel-gfx] [PATCH v3 00/11] Start cleaning up register definitions

Let's start splitting up and cleaning up parts of i915_reg.h. Rather than starting with dead code removal as we did in v1, this time we'll switch a few macros to parameterized style, and then move a few types of registers (engine registers, SNPS PHY registers) off to their own header files.

v3:
- Split out i915_reg_defs.h in its own patch
- Also split out combo PHY and MG/DKL PHY sets of registers

Cc Jani Nikula <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Lucas De Marchi <[email protected]>

Matt Roper (11):
drm/i915: Use parameterized GPR register definitions everywhere drm/i915: Parameterize PWRCTX_MAXCNT
drm/i915: Parameterize ECOSKPD
drm/i915: Use RING_PSMI_CTL rather than per-engine macros drm/i915: Replace GFX_MODE_GEN7 with RING_MODE_GEN7 drm/i915: Introduce i915_reg_defs.h
drm/i915/gt: Move engine registers to their own header drm/i915: Move SNPS PHY registers to their own header drm/i915: Move combo PHY registers to their own header drm/i915: Move TC PHY registers to their own header drm/i915: Drop unused _PORT3 and _PORT4 TC phy register offsets

 drivers/gpu/drm/i915/display/icl_dsi.c        |   1 +
 .../gpu/drm/i915/display/intel_combo_phy.c    |   1 +
 .../drm/i915/display/intel_combo_phy_regs.h   | 162 ++++
 drivers/gpu/drm/i915/display/intel_ddi.c      |   2 +
 .../drm/i915/display/intel_display_power.c    |   1 +
 drivers/gpu/drm/i915/display/intel_dp.c       |   1 +
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |   1 +
 drivers/gpu/drm/i915/display/intel_snps_phy.c |   1 +
 .../drm/i915/display/intel_snps_phy_regs.h    |  75 ++
 drivers/gpu/drm/i915/display/intel_tc.c       |   1 +
 .../gpu/drm/i915/display/intel_tc_phy_regs.h  | 280 ++++++
 drivers/gpu/drm/i915/gt/gen2_engine_cs.c      |   1 +
 drivers/gpu/drm/i915/gt/gen6_engine_cs.c      |   1 +
 drivers/gpu/drm/i915/gt/gen6_ppgtt.c          |   1 +
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |   1 +
 drivers/gpu/drm/i915/gt/intel_engine_regs.h   | 197 ++++
 .../drm/i915/gt/intel_execlists_submission.c  |   1 +
 drivers/gpu/drm/i915/gt/intel_gt.c            |   1 +
 drivers/gpu/drm/i915/gt/intel_lrc.c           |   1 +
 drivers/gpu/drm/i915/gt/intel_lrc_reg.h       |  15 -
 drivers/gpu/drm/i915/gt/intel_rc6.c           |   9 +-
 drivers/gpu/drm/i915/gt/intel_reset.c         |   1 +
 drivers/gpu/drm/i915/gt/intel_ring.c          |   1 +
 .../gpu/drm/i915/gt/intel_ring_submission.c   |  11 +-
 drivers/gpu/drm/i915/gt/intel_workarounds.c   |   7 +-
 drivers/gpu/drm/i915/gt/selftest_engine_pm.c  |   1 +
 drivers/gpu/drm/i915/gt/selftest_gt_pm.c      |   1 +
 drivers/gpu/drm/i915/gt/selftest_rps.c        |   1 +
 drivers/gpu/drm/i915/gt/selftest_timeline.c   |   1 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c    |   1 +
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |   3 +-
 drivers/gpu/drm/i915/gvt/cmd_parser.c         |   1 +
 drivers/gpu/drm/i915/gvt/handlers.c           |   4 +-
 drivers/gpu/drm/i915/gvt/mmio_context.c       |   5 +-
 drivers/gpu/drm/i915/gvt/mmio_context.h       |   1 +
 drivers/gpu/drm/i915/i915_cmd_parser.c        |  69 +-
 drivers/gpu/drm/i915/i915_gpu_error.c         |   1 +
 drivers/gpu/drm/i915/i915_perf.c              |   1 +
 drivers/gpu/drm/i915/i915_pmu.c               |   1 +
 drivers/gpu/drm/i915/i915_reg.h               | 841 +-----------------
 drivers/gpu/drm/i915/i915_reg_defs.h          |  98 ++
 drivers/gpu/drm/i915/i915_request.c           |   1 +
 drivers/gpu/drm/i915/intel_pm.c               |  11 +-
 drivers/gpu/drm/i915/intel_uncore.c           |   2 +-
 44 files changed, 911 insertions(+), 907 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_combo_phy_regs.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_snps_phy_regs.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_tc_phy_regs.h
 create mode 100644 drivers/gpu/drm/i915/gt/intel_engine_regs.h
 create mode 100644 drivers/gpu/drm/i915/i915_reg_defs.h
Signature · 1 line
2.34.1