Skip to content

mptcp: New features and cleanup

Mat Martineau mptcp netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 0 repliesApplied 13/13

Patches in v1 All 13 applied

#Subject and filesSizeRepliesApplied
1/13mptcp: keep snd_una updated for fallback socketnet/mptcp/protocol.c+1 -00 repliesApplied
2/13mptcp: implement fastclose xmit pathnet/mptcp/options.c net/mptcp/protocol.h+46 -120 repliesApplied
3/13mptcp: full disconnect implementationnet/mptcp/pm.c net/mptcp/protocol.c net/mptcp/protocol.h +1 more+98 -280 repliesApplied
4/13mptcp: cleanup accept and pollnet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+7 -200 repliesApplied
5/13mptcp: implement support for user-space disconnectnet/mptcp/protocol.c+13 -40 repliesApplied
6/13selftests: mptcp: add disconnect teststools/testing/selftests/net/mptcp/mptcp_connect.c tools/testing/selftests/net/mptcp/mptcp_connect.sh+160 -270 repliesApplied
7/13mptcp: fix per socket endpoint accountingnet/mptcp/pm_netlink.c+12 -60 repliesApplied
8/13mptcp: clean-up MPJ option writingnet/mptcp/options.c+23 -210 repliesApplied
9/13mptcp: keep track of local endpoint still available for each msknet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/protocol.c +2 more+91 -550 repliesApplied
10/13mptcp: do not block subflows creation on errorsnet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/protocol.c +1 more+71 -310 repliesApplied
11/13selftests: mptcp: add tests for subflow creation failuretools/testing/selftests/net/mptcp/config tools/testing/selftests/net/mptcp/mptcp_join.sh+78 -10 repliesApplied
12/13mptcp: cleanup MPJ subflow list handlingnet/mptcp/pm_netlink.c net/mptcp/protocol.c net/mptcp/protocol.h +2 more+60 -1040 repliesApplied
13/13mptcp: avoid atomic bit manipulation when possiblenet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+38 -310 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 00/13] mptcp: New features and cleanup

These patches have been tested in the MPTCP tree for a longer than usual time (thanks to holiday schedules), and are ready for the net-next branch. Changes include feature updates, small fixes, refactoring, and some selftest changes.

Patch 1 fixes an OUTQ ioctl issue with TCP fallback sockets.

Patches 2, 3, and 6 add support of the MPTCP fastclose option (quick shutdown of the full MPTCP connection, similar to TCP RST in regular TCP), and a related self test.

Patch 4 cleans up some accept and poll code that is no longer needed after the fastclose changes.

Patch 5 add userspace disconnect using AF_UNSPEC, which is used when testing fastclose and makes the MPTCP socket's handling of AF_UNSPEC in connect() more TCP-like.

Patches 7-11 refactor subflow creation to make better use of multiple local endpoints and to better handle individual connection failures when creating multiple subflows. Includes self test updates.

Patch 12 cleans up the way subflows are added to the MPTCP connection list, eliminating the need for calls throughout the MPTCP code that had to check the intermediate "join list" for entries to shift over to the main "connection list".

Patch 13 refactors the MPTCP release_cb flags to use separate storage for values only accessed with the socket lock held (no atomic ops needed), and for values that need atomic operations.

Paolo Abeni (13):
mptcp: keep snd_una updated for fallback socket
mptcp: implement fastclose xmit path
mptcp: full disconnect implementation
mptcp: cleanup accept and poll
mptcp: implement support for user-space disconnect
selftests: mptcp: add disconnect tests
mptcp: fix per socket endpoint accounting
mptcp: clean-up MPJ option writing
mptcp: keep track of local endpoint still available for each msk
mptcp: do not block subflows creation on errors
selftests: mptcp: add tests for subflow creation failure
mptcp: cleanup MPJ subflow list handling
mptcp: avoid atomic bit manipulation when possible

 net/mptcp/options.c                           | 101 ++++--
 net/mptcp/pm.c                                |  34 +-
 net/mptcp/pm_netlink.c                        | 197 ++++++-----
 net/mptcp/protocol.c                          | 307 ++++++++++--------
 net/mptcp/protocol.h                          |  63 ++--
 net/mptcp/sockopt.c                           |  24 +-
 net/mptcp/subflow.c                           |  10 +-
 net/mptcp/token.c                             |   1 +
 tools/testing/selftests/net/mptcp/config      |   1 +
 .../selftests/net/mptcp/mptcp_connect.c       | 148 +++++++--
 .../selftests/net/mptcp/mptcp_connect.sh      |  39 ++-
 .../testing/selftests/net/mptcp/mptcp_join.sh |  83 ++++-
 12 files changed, 683 insertions(+), 325 deletions(-)

base-commit: 710ad98c363a66a0cd8526465426c5c5f8377ee0

Signature · 1 line
2.34.1