Skip to content

tools/libs: decouple more from mini-os

Juergen Gross xen-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 4 repliesIn review
  2. v23 patches 7 repliesSuperseded
  3. v12 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- comments addressed

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tools/libs/evtchn: decouple more from mini-ostools/libs/evtchn/minios.c+96 -471 reply
2/3tools/libs/gnttab: decouple more from mini-ostools/libs/gnttab/minios.c+52 -151 reply
3/3tools/libs/ctrl: remove file related handlingtools/libs/ctrl/xc_minios.c+0 -91 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAndrew CooperSamuel Thibault
1/3R-b
2/3R-b
3/3A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] tools/libs: decouple more from mini-os

This small series removes some hard coupling of the Xen build with some Mini-OS internals, especially the struct file layout and the internal organization of the file handling.

This series depends on the Mini-OS series posted recently:

https://lists.xen.org/archives/html/xen-devel/2022-01/threads.html#00635

The main idea is to no longer have Xen library specific structures inside struct file, or to let struct file layout depend on the configuration of Mini-OS.

All Xen libraries needing a hook in struct file should use the now available generic dev pointer and allocate the needed data dynamically.

Additionally Xen libraries should get the pointer of struct file via the new get_file_from_fd() function instead of accessing directly the files[] array, which might go away in future (e.g. in order to support dynamic allocation of struct file as needed).

Via using alloc_file_type() the libs provide a function vector in order to enable Mini-OS to remove the dedicated callbacks into the libs via known function names and replacing them to use the new vector.

Changes in V3:
- comments addressed

Changes in V2:
- comments addressed
- add using alloc_file_type()
- new patch 3

Juergen Gross (3):
tools/libs/evtchn: decouple more from mini-os
tools/libs/gnttab: decouple more from mini-os
tools/libs/ctrl: remove file related handling

 tools/libs/ctrl/xc_minios.c |   9 ---
 tools/libs/evtchn/minios.c  | 143 ++++++++++++++++++++++++------------
 tools/libs/gnttab/minios.c  |  67 +++++++++++++----
 3 files changed, 148 insertions(+), 71 deletions(-)
Signature · 1 line
2.26.2