Skip to content

staging: r8188eu: move firmware loading out of the hal layer

Michael Straube linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19staging: r8188eu: remove Firmware* from struct hal_data_8188edrivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/rtl8188e_hal.h+5 -100 replies
2/19staging: r8188eu: remove rtl8188e_InitializeFirmwareVars()drivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/rtl8188e_hal.h+3 -130 replies
3/19staging: r8188eu: release_firmware is not called if allocation failsdrivers/staging/r8188eu/hal/rtl8188e_hal_init.c+1 -13 replies
4/19staging: r8188eu: rename Exit label in load_firmware()drivers/staging/r8188eu/hal/rtl8188e_hal_init.c+5 -50 replies
5/19staging: r8188eu: rename rtStatus in load_firmware()drivers/staging/r8188eu/hal/rtl8188e_hal_init.c+6 -60 replies
6/19staging: r8188eu: convert type of return variable in load_firmware()drivers/staging/r8188eu/hal/rtl8188e_hal_init.c+1 -10 replies
7/19staging: r8188eu: rename parameter pFirmware of load_firmware()drivers/staging/r8188eu/hal/rtl8188e_hal_init.c+7 -70 replies
8/19staging: r8188eu: rename fields of struct rt_firmwaredrivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/drv_types.h drivers/staging/r8188eu/os_dep/os_intfs.c+15 -150 replies
9/19staging: r8188eu: use kmemdup instead of kzalloc and memcpydrivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/rtl8188e_hal.h+1 -70 replies
10/19staging: r8188eu: rename fw related functions to avoid camel casedrivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/rtl8188e_hal.h+20 -200 replies
11/19staging: r8188eu: clean up rtw_reset_8051()drivers/staging/r8188eu/hal/rtl8188e_hal_init.c+4 -50 replies
12/19staging: r8188eu: convert two functions from s32 to intdrivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/rtl8188e_hal.h+4 -40 replies
13/19staging: r8188eu: rename Exit label in rtl8188e_firmware_download()drivers/staging/r8188eu/hal/rtl8188e_hal_init.c+4 -40 replies
14/19staging: r8188eu: rename rtSatus in rtl8188e_firmware_download()drivers/staging/r8188eu/hal/rtl8188e_hal_init.c+9 -90 replies
15/19staging: r8188eu: rename FWDL_ChkSum_rptdrivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/rtl8188e_spec.h+3 -30 replies
16/19staging: r8188eu: rename writeFW_retrydrivers/staging/r8188eu/hal/rtl8188e_hal_init.c+4 -40 replies
17/19staging: r8188eu: rename pFwHdr in rtl8188e_firmware_download()drivers/staging/r8188eu/hal/rtl8188e_hal_init.c+6 -60 replies
18/19staging: r8188eu: rename pFirmwareBuf and FirmwareLendrivers/staging/r8188eu/hal/rtl8188e_hal_init.c+7 -70 replies
19/19staging: r8188eu: move firmware loading code out of the hal layerdrivers/staging/r8188eu/Makefile drivers/staging/r8188eu/core/rtw_fw.c drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +3 more+301 -2870 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/19] staging: r8188eu: move firmware loading out of the hal layer

This series starts to clean up firmware related code and moves the firmware loading out of rtl8188e_hal_init.c into the new file core/rtw_fw.c.

Tested on x86_64 with Inter-Tech DMG-02.

Michael Straube (19):
staging: r8188eu: remove Firmware* from struct hal_data_8188e
staging: r8188eu: remove rtl8188e_InitializeFirmwareVars()
staging: r8188eu: release_firmware is not called if allocation fails
staging: r8188eu: rename Exit label in load_firmware()
staging: r8188eu: rename rtStatus in load_firmware()
staging: r8188eu: convert type of return variable in load_firmware()
staging: r8188eu: rename parameter pFirmware of load_firmware()
staging: r8188eu: rename fields of struct rt_firmware
staging: r8188eu: use kmemdup instead of kzalloc and memcpy
staging: r8188eu: rename fw related functions to avoid camel case
staging: r8188eu: clean up rtw_reset_8051()
staging: r8188eu: convert two functions from s32 to int
staging: r8188eu: rename Exit label in rtl8188e_firmware_download()
staging: r8188eu: rename rtSatus in rtl8188e_firmware_download()
staging: r8188eu: rename FWDL_ChkSum_rpt
staging: r8188eu: rename writeFW_retry
staging: r8188eu: rename pFwHdr in rtl8188e_firmware_download()
staging: r8188eu: rename pFirmwareBuf and FirmwareLen
staging: r8188eu: move firmware loading code out of the hal layer

 drivers/staging/r8188eu/Makefile              |   1 +
 drivers/staging/r8188eu/core/rtw_fw.c         | 284 ++++++++++++++++
 .../staging/r8188eu/hal/rtl8188e_hal_init.c   | 303 +-----------------
 drivers/staging/r8188eu/hal/usb_halinit.c     |   8 +-
 drivers/staging/r8188eu/include/drv_types.h   |   4 +-
 .../staging/r8188eu/include/rtl8188e_hal.h    |  10 -
 .../staging/r8188eu/include/rtl8188e_spec.h   |   2 +-
 drivers/staging/r8188eu/include/rtw_fw.h      |  14 +
 drivers/staging/r8188eu/os_dep/os_intfs.c     |   4 +-
 9 files changed, 311 insertions(+), 319 deletions(-)
 create mode 100644 drivers/staging/r8188eu/core/rtw_fw.c
 create mode 100644 drivers/staging/r8188eu/include/rtw_fw.h
Signature · 1 line
2.34.1