Skip to content

remove device specific struct file members

Juergen Gross xen-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 16 repliesIn review
  2. v212 patches 35 repliesSuperseded
  3. v12 patches 8 repliesSuperseded

Changes in v3 from the cover letter

- comments addressed

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12remove event channel specific struct file definitionsConfig.mk arch/x86/testbuild/all-no arch/x86/testbuild/all-yes +3 more+3 -251 reply
2/12remove gnttab specific member from struct fileConfig.mk arch/x86/testbuild/all-no arch/x86/testbuild/all-yes +4 more+2 -130 replies
3/12use alloc_file_type() and get_file_from_fd() in xsinclude/lib.h lib/sys.c lib/xs.c +1 more+52 -353 replies
4/12use alloc_file_type() and get_file_from_fd() in tpm_tisinclude/lib.h include/tpm_tis.h lib/sys.c +1 more+78 -753 replies
5/12use alloc_file_type() and get_file_from_fd() in tpmfrontinclude/lib.h include/tpmfront.h lib/sys.c +1 more+69 -621 reply
6/12use alloc_file_type() and get_file_from_fd() in blkfrontblkfront.c include/blkfront.h include/lib.h +1 more+69 -553 replies
7/12use alloc_file_type() and get_file_from_fd() in netfrontinclude/lib.h include/netfront.h lib/sys.c +1 more+59 -351 reply
8/12use alloc_file_type() and get_file_from_fd() in fbfrontfbfront.c include/lib.h lib/sys.c+108 -701 reply
9/12use file_ops and get_file_from_fd() for consoleconsole/console.c console/xenbus.c console/xencons_ring.c +3 more+144 -731 reply
10/12add struct file_ops for file type socketlib/sys.c+64 -841 reply
11/12add struct file_ops for FTYPE_FILElib/sys.c+9 -100 replies
12/12make files array private to sys.cinclude/lib.h lib/sys.c+1 -30 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchSamuel Thibault
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [MINIOS PATCH v3 00/12] remove device specific struct file members

This series is a followup to the series sent recently:

https://lists.xen.org/archives/html/xen-devel/2022-01/threads.html#00635

It contains the last cleanups related to struct file and can only be applied after the Xen libraries have stopped using the related union members:

https://lists.xen.org/archives/html/xen-devel/2022-01/threads.html#00643

The three series applied have been tested to work with:

- xenstorepvh-stubdom
- pv-grub
- ioemu-stubdom

Changes in V3:
- comments addressed

Changes in V2:
- add many patches for using alloc_file_type() and struct file_ops

Juergen Gross (12):
remove event channel specific struct file definitions remove gnttab specific member from struct file use alloc_file_type() and get_file_from_fd() in xs use alloc_file_type() and get_file_from_fd() in tpm_tis use alloc_file_type() and get_file_from_fd() in tpmfront use alloc_file_type() and get_file_from_fd() in blkfront use alloc_file_type() and get_file_from_fd() in netfront use alloc_file_type() and get_file_from_fd() in fbfront use file_ops and get_file_from_fd() for console add struct file_ops for file type socket
add struct file_ops for FTYPE_FILE
make files array private to sys.c

 Config.mk                     |   2 -
 arch/x86/testbuild/all-no     |   2 -
 arch/x86/testbuild/all-yes    |   2 -
 arch/x86/testbuild/newxen-yes |   2 -
 blkfront.c                    |  92 ++++++--
 console/console.c             |   2 +-
 console/xenbus.c              | 112 +++++++++
 console/xencons_ring.c        |   6 +-
 fbfront.c                     | 127 ++++++++--
 gntmap.c                      |   2 +-
 include/blkfront.h            |   5 -
 include/console.h             |   7 +-
 include/lib.h                 |  29 +--
 include/netfront.h            |   3 +-
 include/tpm_tis.h             |   6 -
 include/tpmfront.h            |   5 -
 lib/sys.c                     | 424 ++++++++--------------------------
 lib/xs.c                      |  65 ++++--
 netfront.c                    |  65 +++++-
 tpm_tis.c                     | 121 ++++++----
 tpmfront.c                    | 100 +++++---
 xenbus/xenbus.c               |   1 +
 22 files changed, 649 insertions(+), 531 deletions(-)
Signature · 1 line
2.26.2