Skip to content

Add support for Maxim MAX735x/MAX736x variants

Patrick Rudolph linux-devicetree linux-i2c lkml 16 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v16 Latest4 patches 4 repliesIn review
  2. v154 patches 12 repliesApplied
  3. v144 patches 5 repliesSuperseded
Earlier versions · 13
VersionPostedPatchesRepliesStatus
v134 patches4 repliesSuperseded
v124 patches4 repliesSuperseded
v113 patches4 repliesSuperseded
v10 posting 2/23 patches2 repliesSuperseded
v10 posting 1/23 of 4 patches1 replySuperseded
v94 patches8 repliesSuperseded
v83 patches3 repliesSuperseded
v73 patches2 repliesSuperseded
v63 patches7 repliesSuperseded
v53 patches1 replySuperseded
v43 patches2 repliesSuperseded
v33 patches1 replySuperseded
v24 patches4 repliesSuperseded

Changes in v16 from the cover letter

- Fix comment style
- Remove copyright

Patches in v16 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4dt-bindings: i2c: pca954x: Correct interrupt supportDocumentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml+19 -41 reply
2/4dt-bindings: i2c: Add Maxim MAX735x/MAX736x variantsDocumentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml+21 -21 reply
3/4i2c: muxes: pca954x: Add MAX735x/MAX736x supportdrivers/i2c/muxes/Kconfig drivers/i2c/muxes/i2c-mux-pca954x.c+69 -41 reply
4/4i2c: muxes: pca954x: Add regulator supportdrivers/i2c/muxes/i2c-mux-pca954x.c+23 -51 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiAndi ShytiPeter Rosin
1/4R-b A-b
2/4R-b A-b
3/4R-b A-b
4/4R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v16 thread

Cover letter [v16 0/4] Add support for Maxim MAX735x/MAX736x variants

v16:
- Fix comment style
- Remove copyright

v15:
- Clarified VDD usage on PCA9846 which has two VDD pins

v14:
- Added comment for interrupt support

v13:
- Fix dt-binding
- Fixed nits

v12:
- Add separate patch correcting interrupt support in dt-binding
- Fix typo in commit message
- Make vdd-supply non optional

v11:
- Fix dt-binding example

v10:
- Small updates to dt-bindings
- Make vdd-supply optional
- Drop MAX7357 enhanced mode configuration

v9:
- Fix 'then' not aligned with 'if' in dt-bindings
- Split enhanced mode configuration into separate patch
- Add MAX7357/MAX7358 register definitions
- Rename config register defines
- Update comments and explain non default config being applied on MAX7357
- Check for I2C_FUNC_SMBUS_WRITE_BYTE_DATA functionality

v8:
- Move allOf in dt-binding and use double negation

v7:
- Reworked the commit message, comments and renamed a struct field. No functional change.

v6:
- Fix typo in dt-bindings

v5:
- Remove optional and make vdd-supply mandatory

v4:
- Add missing maxitems dt-bindings property

v3:
- Merge dt-bindings into i2c-mux-pca954x.yaml

v2:
- Move dt-bindings to separate file
- Added support for MAX736x as they are very similar
- Fixed an issue found by kernel test robot
- Dropped max735x property and custom IRQ check
- Added MAX7357 config register defines instead of magic values
- Renamed vcc-supply to vdd-supply

Patrick Rudolph (4):
dt-bindings: i2c: pca954x: Correct interrupt support
dt-bindings: i2c: Add Maxim MAX735x/MAX736x variants
i2c: muxes: pca954x: Add MAX735x/MAX736x support
i2c: muxes: pca954x: Add regulator support

 .../bindings/i2c/i2c-mux-pca954x.yaml         | 46 +++++++--
 drivers/i2c/muxes/Kconfig                     |  6 +-
 drivers/i2c/muxes/i2c-mux-pca954x.c           | 95 +++++++++++++++++--
 3 files changed, 132 insertions(+), 15 deletions(-)
Signature · 1 line
2.41.0