Skip to content

pinctrl: mediatek: Support pinctrl driver on mt8186

Guodong Liu linux-arm-kernel linux-devicetree linux-gpio linux-mediatek lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 4 repliesIn review
  2. v43 patches 4 repliesSuperseded
  3. v3 posting 2/23 patches 10 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v3 posting 1/20 of 2 patches0 repliesSuperseded
v22 patches6 repliesSuperseded
v12 patches1 replySuperseded

Changes in v5 from the cover letter

- update mt8186 pull up RSEL type define value
- update mt8186 pull up RSEL type si unit value(ohm)
- update macro definition name
- update mt8186 bias resistance selectio register description

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: pinctrl: mt8186: add pinctrl file and binding documentDocumentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml include/dt-bindings/pinctrl/mt8186-pinfunc.h+1471 -02 replies
2/3pinctrl: add pinctrl driver on mt8186drivers/pinctrl/mediatek/Kconfig drivers/pinctrl/mediatek/Makefile drivers/pinctrl/mediatek/pinctrl-mt8186.c +1 more+3465 -01 reply
3/3pinctrl: canonical rsel resistance selection propertydrivers/pinctrl/mediatek/pinctrl-paris.c+1 -10 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] pinctrl: mediatek: Support pinctrl driver on mt8186

changes since v4:
- update mt8186 pull up RSEL type define value
- update mt8186 pull up RSEL type si unit value(ohm)
- update macro definition name
- update mt8186 bias resistance selectio register description

changes since v3:
- remove generic descriptions for common properties
- remove quotes
- drop "."
- drop "-" on description
- move partial "bias-pull-up" description info to the example
- don't break the code into two lines, maximux 84 columns is fine
- add the required fixes tag

changes since v2:
- update reg property
- update reg-names property
- sync rsel resistance selection property same as patch 3
- repair constraints is not indented correctly for bias-pull-{up,down}
- add "type: boolean" to the list of valid values. This corresponds to having bias-pull-{up,down} without any arguments.
- add dual file license for file "mt8186-pinfunc.h"
- add patch 3 to change "mediatek,rsel_resistance_in_si_unit" to "mediatek,rsel-resistance-in-si-unit"

changes since v1:
- add default pinctrl config to consistent with other MTK pinctrl drivers

Patch 1 add pinctrl file and binding document.

Patch 2 add pinctrl chip driver on mt8186.

Patch 3 canonical rsel resistance selection property.

Guodong Liu (3):
dt-bindings: pinctrl: mt8186: add pinctrl file and binding document
pinctrl: add pinctrl driver on mt8186
pinctrl: canonical rsel resistance selection property

 .../bindings/pinctrl/pinctrl-mt8186.yaml      |  297 +++
 drivers/pinctrl/mediatek/Kconfig              |    7 +
 drivers/pinctrl/mediatek/Makefile             |    1 +
 drivers/pinctrl/mediatek/pinctrl-mt8186.c     | 1271 ++++++++++
 drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h | 2186 +++++++++++++++++
 drivers/pinctrl/mediatek/pinctrl-paris.c      |    2 +-
 include/dt-bindings/pinctrl/mt8186-pinfunc.h  | 1174 +++++++++
 7 files changed, 4937 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
 create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt8186.c
 create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h
 create mode 100644 include/dt-bindings/pinctrl/mt8186-pinfunc.h
Signature · 1 line
2.25.1