Skip to content

target/ppc: powerpc_excp improvements [40x] (3/n)

Fabiano Rosas qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 29 repliesIn review
  2. v18 patches 16 repliesSuperseded

Changes in v2 from the cover letter

- New patch that renames MSR_POW to MSR_WE for the 405.

- New patch that adds just MSR_ME to the msr_mask.

- New patches to cleanup exceptions I missed the first time around.

- Dropped the patch that added all the missing MSR bits. We have an issue when two different MSR bits share the same number in different CPUs. Described in v1 here:

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14target/ppc: 405: Rename MSR_POW to MSR_WEtarget/ppc/cpu.h target/ppc/cpu_init.c+2 -11 reply
2/14target/ppc: 405: Add missing MSR_ME bittarget/ppc/cpu_init.c+1 -01 reply
3/14target/ppc: Introduce powerpc_excp_40xtarget/ppc/excp_helper.c+474 -02 replies
4/14target/ppc: Simplify powerpc_excp_40xtarget/ppc/excp_helper.c+10 -1951 reply
5/14target/ppc: 405: Critical exceptions cleanuptarget/ppc/excp_helper.c+2 -151 reply
6/14target/ppc: 405: Machine check exception cleanuptarget/ppc/excp_helper.c+2 -242 replies
7/14target/ppc: 405: External exception cleanuptarget/ppc/excp_helper.c+0 -372 replies
8/14target/ppc: 405: System call exception cleanuptarget/ppc/excp_helper.c+2 -195 replies
9/14target/ppc: 405: Alignment exception cleanuptarget/ppc/excp_helper.c+0 -71 reply
10/14target/ppc: 405: Debug exception cleanuptarget/ppc/excp_helper.c+4 -141 reply
11/14target/ppc: 405: Data Storage exception cleanuptarget/ppc/excp_helper.c+1 -14 replies
12/14target/ppc: 405: Instruction storage interrupt cleanuptarget/ppc/excp_helper.c+0 -12 replies
13/14target/ppc: 405: Program exception cleanuptarget/ppc/excp_helper.c+0 -164 replies
14/14target/ppc: 405: Watchdog timer exception cleanuptarget/ppc/excp_helper.c+0 -91 reply

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by.

PatchDavid GibsonCédric Le GoaterRichard Henderson
1/14R-b
2/14R-b
3/14R-b R-b
4/14R-b
5/14R-b R-b
6/14R-b
7/14R-b
8/14R-b R-b
9/14R-b
10/14R-b
11/14R-b
12/14R-b
13/14R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/14] target/ppc: powerpc_excp improvements [40x] (3/n)

changes from v1:

- New patch that renames MSR_POW to MSR_WE for the 405.

- New patch that adds just MSR_ME to the msr_mask.

- New patches to cleanup exceptions I missed the first time around.

- Dropped the patch that added all the missing MSR bits. We have an issue when two different MSR bits share the same number in different CPUs. Described in v1 here:

https://lists.nongnu.org/archive/html/qemu-ppc/2022-01/msg00503.html

- Dropped the patch that adds missing exception vectors because Linux clearly cannot handle them. And I don't have access to real hardware to confirm some of the questions raised, so let's keep things as they are.

- Kept the split in two patches. One that copies powerpc_excp_legacy and other that does the changes.

Based on legoater/ppc-7.0

With only the fixes from the above branch, the ref405ep machine boots until the shell. This series doesn't change that.

v1:
https://lists.nongnu.org/archive/html/qemu-ppc/2022-01/msg00300.html

Fabiano Rosas (14):
target/ppc: 405: Rename MSR_POW to MSR_WE target/ppc: 405: Add missing MSR_ME bit target/ppc: Introduce powerpc_excp_40x target/ppc: Simplify powerpc_excp_40x target/ppc: 405: Critical exceptions cleanup target/ppc: 405: Machine check exception cleanup target/ppc: 405: External exception cleanup target/ppc: 405: System call exception cleanup target/ppc: 405: Alignment exception cleanup target/ppc: 405: Debug exception cleanup target/ppc: 405: Data Storage exception cleanup target/ppc: 405: Instruction storage interrupt cleanup target/ppc: 405: Program exception cleanup target/ppc: 405: Watchdog timer exception cleanup

 target/ppc/cpu.h         |   1 +
 target/ppc/cpu_init.c    |   3 +-
 target/ppc/excp_helper.c | 159 ++++++++++++++++++++++++++++++++++++++-
 3 files changed, 161 insertions(+), 2 deletions(-)
Signature · 1 line
2.33.1