Skip to content

python: fix for mypy 0.930 and pylint dependencies

John Snow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3python/aqmp: use absolute import statementpython/qemu/aqmp/aqmp_tui.py+2 -11 reply
2/3Python/aqmp: fix type definitions for mypy 0.920python/qemu/aqmp/protocol.py+3 -20 replies
3/3python: update type hints for mypy 0.930python/qemu/qmp/qom_common.py+1 -51 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchBeraldo Leal
1/3R-b
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] python: fix for mypy 0.930 and pylint dependencies

GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-ci-fix-2022-jan
CI: https://gitlab.com/jsnow/qemu/-/pipelines/445011098

Dependencies in the Python ecosystem were updated and caused CI failures immediately after leaving for PTO. This series fixes those breakages, thank you for your patience.

This patchset fixes the 'check-python-tox' job that was previously configured as 'allowed to fail'. I'm not re-enabling it to always run at present, maybe leaving it as an optional job is fine for now. The purpose of the job is primarily to find new breakages on cutting edge deployments of Python, which means that it's fairly likely to chirp as regressions are discovered.

Generally, I like seeing those regressions so I can keep on top of fixing them -- however, in practice, it seems as if what this really means is that every last time I go on PTO, they break for several weeks in an amazing coincidence.

Oh well.

When submitting Python changes in the future, please just check that this CI test ran to ensure that it works well on all supported Python interpreter versions.

John Snow (3):
python/aqmp: use absolute import statement Python/aqmp: fix type definitions for mypy 0.920
python: update type hints for mypy 0.930

 python/qemu/aqmp/aqmp_tui.py  | 3 ++-
 python/qemu/aqmp/protocol.py  | 5 +++--
 python/qemu/qmp/qom_common.py | 6 +-----
 3 files changed, 6 insertions(+), 8 deletions(-)
Signature · 1 line
2.31.1