Skip to content

fw_env: two minor code cleanups

Rafał Miłecki u-boot 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 0 repliesSuperseded
  3. v12 patches 1 replySuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2fw_env: make flash_io() take buffer as an argumenttools/env/fw_env.c+16 -161 reply
2/2fw_env: simplify logic & code paths in the fw_env_open()tools/env/fw_env.c+31 -461 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH V3 0/2] fw_env: two minor code cleanups

From: Rafał Miłecki <[email protected]>

Hi,

I'm a long time OpenWrt developer and just recently I started working with some devices using U-Boot.

I was trying to understand how environment variables are read in user space and I had some problems understanding fw_env_open() logic. I eventually got it but I thought I may help further developers by simpliifying its code a bit.

I hope you may find those patches useful and review / apply them.

Rafał Miłecki (2):
fw_env: make flash_io() take buffer as an argument
fw_env: simplify logic & code paths in the fw_env_open()

 tools/env/fw_env.c | 105 +++++++++++++++++++--------------------------
 1 file changed, 45 insertions(+), 60 deletions(-)
Signature · 1 line
2.31.1