Skip to content

Use -Werror by default and fix compilation warnings

Rodrigo Siqueira amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/amdgpu: Treat warning as an errordrivers/gpu/drm/amd/amdgpu/Makefile+2 -03 replies
2/4drm/amdgpu: Fix compilation warning due to double semicolondrivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c+2 -20 replies
3/4drm/amdgpu: Drop unused variabledrivers/gpu/drm/amd/amdgpu/amdgpu_ras.c+0 -10 replies
4/4drm/amdgpu: Silent GCC warningdrivers/gpu/drm/amd/amdgpu/amdgpu_ras.h+1 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Use -Werror by default and fix compilation warnings

We have an internal CI in the display team that uses a stable version of amd-staging-drm-next to run a set of tests (from compilation to IGT); usually, we have to create this stable version manually. We are trying to automate this process, but we are getting failures because we compile display code with the flag -Werror, which means we cannot ignore warnings in amd-staging-drm-next. In this patchset, I propose enabling -Werror flag by default in amdgpu to make it a little bit harder to ignore warning messages. The first patch of this series updates amdgpu Makefile, and the other patches fix warning issues in amdgpu.

I tested this series with DCN, DCN disabled, and with allmodconfig; I did not have any compilation issue.

Thanks
Siqueira

Rodrigo Siqueira (4):
drm/amdgpu: Treat warning as an error
drm/amdgpu: Fix compilation warning due to double semicolon drm/amdgpu: Drop unused variable
drm/amdgpu: Silent GCC warning

 drivers/gpu/drm/amd/amdgpu/Makefile      | 2 ++
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c  | 1 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h  | 1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 4 ++--
 4 files changed, 5 insertions(+), 3 deletions(-)
Signature · 1 line
2.25.1