target/s390x: Fix shift instructions
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 5 repliesIn review
- v35 patches 2 repliesSuperseded
- v25 patches 8 repliesSuperseded
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | target/s390x: Fix SLDA sign bit indextarget/ | +1 | 0 replies | |
| 2/5 | target/s390x: Fix SRDA CC calculationtarget/ | +4 | 1 reply | |
| 3/5 | target/s390x: Fix cc_calc_sla_64() missing overflowstarget/ | +1 | 1 reply | |
| 4/5 | target/s390x: Fix shifting 32-bit values for more than 31 bitstarget/ target/ target/ +2 more | +45 | 1 reply | |
| 5/5 | tests/tcg/s390x: Test shift instructionstests/ tests/ | +271 | 1 reply |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | David Hildenbrand |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | R-b |
| 5/5 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/5] target/s390x: Fix shift instructions
v3: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02680.html
v3 -> v4: Simplify cc_calc_sla().
Free temporaries.
v2: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02488.html
v2 -> v3: Unify CC_OP_SLA_32 and CC_OP_SLA_64.
Add underscores to test macro parameters.
Shift CC in test asm.
Add a second SLAG test.
Add tags to commit messages.
v1: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02035.html
v1 -> v2: Fix cc_calc_sla_32().
Fix cc_calc_sla_64().
Fix SLDA sign bit index.
Inline help_l2_shift().
Fix wout_r1_D32().
Add all shift instructions to the test.
Split the series.
Ilya Leoshkevich (5):
target/s390x: Fix SLDA sign bit index
target/s390x: Fix SRDA CC calculation
target/s390x: Fix cc_calc_sla_64() missing overflows target/s390x: Fix shifting 32-bit values for more than 31 bits tests/tcg/s390x: Test shift instructions
target/s390x/cpu-dump.c | 3 +- target/s390x/s390x-internal.h | 3 +- target/s390x/tcg/cc_helper.c | 38 +---- target/s390x/tcg/insn-data.def | 36 ++--- target/s390x/tcg/translate.c | 53 +++---- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/shift.c | 270 ++++++++++++++++++++++++++++++++ 7 files changed, 321 insertions(+), 83 deletions(-) create mode 100644 tests/tcg/s390x/shift.c
Signature · 1 line
2.31.1