Skip to content

acpi: fix short OEM [Table] ID padding

Igor Mammedov qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 23 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tests: acpi: manually pad OEM_ID/OEM_TABLE_ID for test_oem_fields() testtests/qtest/bios-tables-test.c+6 -93 replies
2/4tests: acpi: whitelist nvdimm's SSDT and FACP.slic expected blobstests/qtest/bios-tables-test-allowed-diff.h+4 -00 replies
3/4acpi: fix OEM ID/OEM Table ID paddinghw/acpi/aml-build.c+2 -215 replies
4/4tests: acpi: update expected blobstests/data/acpi/pc/SSDT.dimmpxm tests/data/acpi/q35/FACP.slic tests/data/acpi/q35/SSDT.dimmpxm +2 more+0 -41 reply

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAni SinhaDmitry V. Orekhov
SeriesR-b
1/4
2/4
3/4R-b T-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] acpi: fix short OEM [Table] ID padding

Since 6.0 the commit:
602b458201 ("acpi: Permit OEM ID and OEM table ID fields to be changed")
regressed values of OEM [Table] ID fields in ACPI tables
by padding them with whitespace is a value is shorter then
max possible. That depending on vendor broke OEM [Table] ID patching with SLIC table values and as result licensing of Windows guests.

First reported here https://gitlab.com/qemu-project/qemu/-/issues/707

CC Marian Postevca <[email protected]>
CC Michael S. Tsirkin <[email protected]>
CC Ani Sinha <[email protected]>

Igor Mammedov (4):
tests: acpi: manually pad OEM_ID/OEM_TABLE_ID for test_oem_fields()
test
tests: acpi: whitelist nvdimm's SSDT and FACP.slic expected blobs
acpi: fix OEM ID/OEM Table ID padding
tests: acpi: update expected blobs

 hw/acpi/aml-build.c              |   4 ++--
 tests/data/acpi/pc/SSDT.dimmpxm  | Bin 734 -> 734 bytes
 tests/data/acpi/q35/FACP.slic    | Bin 244 -> 244 bytes
 tests/data/acpi/q35/SSDT.dimmpxm | Bin 734 -> 734 bytes
 tests/data/acpi/virt/SSDT.memhp  | Bin 736 -> 736 bytes
 tests/qtest/bios-tables-test.c   |  15 ++++++---------
 6 files changed, 8 insertions(+), 11 deletions(-)
Signature · 1 line
2.31.1