Skip to content

git-p4: Various code tidy-ups

Joel Holdsworth git 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest22 patches 2 repliesIn review
  2. v422 patches 8 repliesSuperseded
  3. v321 patches 7 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v221 patches2 repliesSuperseded
v120 patches6 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22git-p4: add blank lines between functions and class definitionsgit-p4.py+107 -00 replies
2/22git-p4: remove unneeded semicolons from statementsgit-p4.py+14 -140 replies
3/22git-p4: indent with 4-spacesgit-p4.py+9 -90 replies
4/22git-p4: improve consistency of docstring formattinggit-p4.py+158 -1330 replies
5/22git-p4: convert descriptive class and function comments into docstringsgit-p4.py+94 -700 replies
6/22git-p4: remove commented codegit-p4.py+0 -70 replies
7/22git-p4: sort and de-duplcate pylint disable listgit-p4.py+22 -70 replies
8/22git-p4: remove padding from lists, tuples and function argumentsgit-p4.py+18 -180 replies
9/22git-p4: remove spaces around default argumentsgit-p4.py+6 -60 replies
10/22git-p4: removed brackets when assigning multiple return valuesgit-p4.py+19 -190 replies
11/22git-p4: place a single space after every commagit-p4.py+9 -90 replies
12/22git-p4: remove extraneous spaces before function argumentsgit-p4.py+11 -110 replies
13/22git-p4: remove redundant backslash-continuations inside bracketsgit-p4.py+9 -90 replies
14/22git-p4: remove spaces between dictionary keys and colonsgit-p4.py+7 -70 replies
15/22git-p4: ensure every comment has a single #git-p4.py+6 -60 replies
16/22git-p4: ensure there is a single space around all operatorsgit-p4.py+5 -50 replies
17/22git-p4: normalize indentation of lines in conditionalsgit-p4.py+7 -90 replies
18/22git-p4: compare to singletons with "is" and "is not"git-p4.py+3 -30 replies
19/22git-p4: only seperate code blocks by a single empty linegit-p4.py+0 -30 replies
20/22git-p4: move inline comments to line abovegit-p4.py+7 -30 replies
21/22git-p4: seperate multiple statements onto seperate linesgit-p4.py+5 -20 replies
22/22git-p4: sort importsgit-p4.py+10 -80 replies

Reviews trailers per patch

None of the 22 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTao Klerks
SeriesR-b
1/22
2/22
3/22
4/22
5/22
6/22
7/22
8/22
9/22
10/22
11/22
12/22
13/22
14/22
15/22
16/22
17/22
18/22
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/22] git-p4: Various code tidy-ups

This patch set contains multiple patches to improve consistency and tidyness of the git-p4 script's code style.

Many of these patches have been driven by the guidlines contained in the Python PEP8 "Style Guide for Python Code" and were applied using a mixture of human intervention, and tools including autopep8 and pycodestyle.

This patch-set stops short of bringing git-p4 into full PEP8 compliance, most notably in regard to the following items:

- There is no patch to apply the recommended column limit of

    79-characters,

- There is no patch to correct hanging indents of multi-line declarations such as multi-line function delcarations, function invocations, etc.

Patches to correct these items may be provided later.

This fifth version of the patch-set adds a missing Signed-off-by label to the final patch.

Joel Holdsworth (22):
git-p4: add blank lines between functions and class definitions
git-p4: remove unneeded semicolons from statements
git-p4: indent with 4-spaces
git-p4: improve consistency of docstring formatting
git-p4: convert descriptive class and function comments into
docstrings
git-p4: remove commented code
git-p4: sort and de-duplcate pylint disable list
git-p4: remove padding from lists, tuples and function arguments
git-p4: remove spaces around default arguments
git-p4: removed brackets when assigning multiple return values
git-p4: place a single space after every comma
git-p4: remove extraneous spaces before function arguments
git-p4: remove redundant backslash-continuations inside brackets
git-p4: remove spaces between dictionary keys and colons
git-p4: ensure every comment has a single #
git-p4: ensure there is a single space around all operators
git-p4: normalize indentation of lines in conditionals
git-p4: compare to singletons with "is" and "is not"
git-p4: only seperate code blocks by a single empty line
git-p4: move inline comments to line above
git-p4: seperate multiple statements onto seperate lines
git-p4: sort imports

 git-p4.py | 882 ++++++++++++++++++++++++++++++++----------------------
 1 file changed, 525 insertions(+), 357 deletions(-)
Signature · 1 line
2.35.GIT