app/testpmd: skip stopped queues when forwarding
Status from this message: Applied in next-net, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest2 patches 4 repliesApplied
- v22 patches 0 repliesSuperseded
- v11 patch 8 repliesSuperseded
Changes in v3 from the cover letter
* Revert to storing queue status in testpmd to handle PMDs that don't implement rte_eth_rx/tx_queue_info_get() (Daxue Gao).
* Add missed "macswap" support.
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | app/testpmd: do not poll stopped queuesapp/ app/ app/ +13 more | +244 | 4 replies | |
| 2/2 | ethdev: prohibit polling of a stopped queuelib/ | +1 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Matan Azrad |
|---|---|
| 1/2 | A-b |
| 2/2 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/2] app/testpmd: skip stopped queues when forwarding
It was unspecified what happens of a stopped queue is polled. Declare that polling is prohibited and modify testpmd to follow this. Rationale is described in the commit log; it follows the discussion:
http://inbox.dpdk.org/dev/BL1PR12MB594551A71273709E1C04A8BAB9309@BL1PR12MB5945.namprd12.prod.outlook.com/
v3:
* Revert to storing queue status in testpmd to handle PMDs that don't implement rte_eth_rx/tx_queue_info_get() (Daxue Gao).
* Add missed "macswap" support.
v2:
* Do not try to change forwarding mode partially, disable individual flows that need stopped queues instead.
* Do not store queue status in testpmd,
query it as needed instead.
Dmitry Kozlyuk (2):
app/testpmd: do not poll stopped queues
ethdev: prohibit polling of a stopped queue
app/test-pmd/5tswap.c | 13 +++++ app/test-pmd/cmdline.c | 45 +++++++++------- app/test-pmd/config.c | 8 +-- app/test-pmd/csumonly.c | 13 +++++ app/test-pmd/flowgen.c | 13 +++++ app/test-pmd/icmpecho.c | 13 +++++ app/test-pmd/ieee1588fwd.c | 13 +++++ app/test-pmd/iofwd.c | 13 +++++ app/test-pmd/macfwd.c | 13 +++++ app/test-pmd/macswap.c | 13 +++++ app/test-pmd/noisy_vnf.c | 13 +++++ app/test-pmd/rxonly.c | 8 +++ app/test-pmd/shared_rxq_fwd.c | 8 +++ app/test-pmd/testpmd.c | 96 +++++++++++++++++++++++------------ app/test-pmd/testpmd.h | 19 ++++++- app/test-pmd/txonly.c | 8 +++ lib/ethdev/rte_ethdev.h | 2 +- 17 files changed, 254 insertions(+), 57 deletions(-)
Signature · 1 line
2.25.1