Skip to content

vmsd checks

Dr. David Alan Gilbert (git) qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 patches 13 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ppc: Fix vmstate_pbr403 subsection nametarget/ppc/machine.c+1 -13 replies
2/3migration: Add canary to VMSTATE_END_OF_LISTinclude/migration/vmstate.h migration/savevm.c migration/vmstate.c+9 -13 replies
3/3migration: Perform vmsd structure check during testsmigration/savevm.c+39 -07 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPeter MaydellPhilippe Mathieu-DaudéJuan Quintela
1/3R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/3] vmsd checks

From: "Dr. David Alan Gilbert" <[email protected]>

Aftern the patch the other day where I added a missing END_OF_LIST, Peter suggested adding something more robust.

Here I:
add a check for a flag at the end of the list
add a check that's performed in vmstate_register_with_alias_id
only within qtest recursively for that canary and for subsection naming constraints.
Fix a ppc issue that the vmstate naming constraint caught
(Waiting for a reply from the PPC folk to check that).

The checks can't go in until I get the def into libslirp.

Dr. David Alan Gilbert (3):
ppc: Fix vmstate_pbr403 subsection name
migration: Add canary to VMSTATE_END_OF_LIST
migration: Perform vmsd structure check during tests

 include/migration/vmstate.h |  7 ++++++-
 migration/savevm.c          | 40 +++++++++++++++++++++++++++++++++++++
 migration/vmstate.c         |  2 ++
 target/ppc/machine.c        |  2 +-
 4 files changed, 49 insertions(+), 2 deletions(-)
Signature · 1 line
2.34.1