Skip to content

drm: bridge: icn6211: Fix hard-coded panel settings and add I2C support

Marek Vasut dri-devel 6 versions – Applied

Status from this message: Applied to drm-misc-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest11 patches 1 replyApplied
  2. v511 patches 4 repliesSuperseded
  3. v413 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v313 patches29 repliesSuperseded
v212 patches16 repliesSuperseded
v114 patches7 repliesSuperseded

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/11drm: bridge: icn6211: Fix register layoutdrivers/gpu/drm/bridge/chipone-icn6211.c+117 -170 replies
2/11drm: bridge: icn6211: Fix HFP_HSW_HBP_HI and HFP_MIN handlingdrivers/gpu/drm/bridge/chipone-icn6211.c+16 -70 replies
3/11drm: bridge: icn6211: Add HS/VS/DE polarity handlingdrivers/gpu/drm/bridge/chipone-icn6211.c+15 -10 replies
4/11drm: bridge: icn6211: Add generic DSI-to-DPI PLL configurationdrivers/gpu/drm/bridge/chipone-icn6211.c+86 -30 replies
5/11drm: bridge: icn6211: Use DSI burst mode without EoT and with LP command modedrivers/gpu/drm/bridge/chipone-icn6211.c+2 -10 replies
6/11drm: bridge: icn6211: Disable DPI color swapdrivers/gpu/drm/bridge/chipone-icn6211.c+1 -00 replies
7/11drm: bridge: icn6211: Set SYS_CTRL_1 to value used in examplesdrivers/gpu/drm/bridge/chipone-icn6211.c+1 -10 replies
8/11drm: bridge: icn6211: Implement atomic_get_input_bus_fmtsdrivers/gpu/drm/bridge/chipone-icn6211.c+27 -00 replies
9/11drm: bridge: icn6211: Add I2C configuration supportdrivers/gpu/drm/bridge/chipone-icn6211.c+156 -220 replies
10/11drm: bridge: icn6211: Rework ICN6211_DSI to chipone_writeb()drivers/gpu/drm/bridge/chipone-icn6211.c+39 -470 replies
11/11drm: bridge: icn6211: Read and validate chip IDs before configurationdrivers/gpu/drm/bridge/chipone-icn6211.c+23 -10 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchMaxime Ripard
1/11A-b
2/11A-b
3/11A-b
4/11A-b
5/11A-b
6/11A-b
7/11A-b
8/11A-b
9/11A-b
10/11A-b
11/11A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/11] drm: bridge: icn6211: Fix hard-coded panel settings and add I2C support

This series fixes multiple problems with the ICN6211 driver and adds support for configuration of the chip via I2C bus.

First, in the current state, the ICN6211 driver hard-codes DPI timing and clock settings specific to some unknown panel. The settings provided by panel driver are ignored. Using any other panel than the one for which this driver is currently hard-coded can lead to permanent damage of the panel (per display supplier warning, and it sure did in my case. The damage looks like multiple rows of dead pixels at the bottom of the panel, and this is not going away even after long power off time).

Much of this series thus fixes incorrect register layout, DPI timing programming, clock generation by adding actual PLL configuration code. This series no longer adds lane count decoding and retains current hard-coded lane count 4 due to disagreement over lane count parsing from DT. The lane count support will come later. The series also fills in a couple of registers with likely correct default values.

Second, this series adds support for I2C configuration of the ICN6211. The device can be configured either via DSI command mode or via I2C, the register layout is the same in both cases.

Since the datasheet for this device is very hard to come by, a lot of information has been salvaged from [1] and [2].

[1] https://github.com/rockchip-linux/kernel/blob/develop-4.19/drivers/gpu/drm/bridge/icn6211.c
[2] https://github.com/tdjastrzebski/ICN6211-Configurator

Cc: Jagan Teki <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: Robert Foss <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: Thomas Zimmermann <[email protected]>
To: [email protected]

Marek Vasut (11):
drm: bridge: icn6211: Fix register layout
drm: bridge: icn6211: Fix HFP_HSW_HBP_HI and HFP_MIN handling
drm: bridge: icn6211: Add HS/VS/DE polarity handling
drm: bridge: icn6211: Add generic DSI-to-DPI PLL configuration
drm: bridge: icn6211: Use DSI burst mode without EoT and with LP
command mode
drm: bridge: icn6211: Disable DPI color swap
drm: bridge: icn6211: Set SYS_CTRL_1 to value used in examples
drm: bridge: icn6211: Implement atomic_get_input_bus_fmts
drm: bridge: icn6211: Add I2C configuration support
drm: bridge: icn6211: Rework ICN6211_DSI to chipone_writeb()
drm: bridge: icn6211: Read and validate chip IDs before configuration

 drivers/gpu/drm/bridge/chipone-icn6211.c | 491 ++++++++++++++++++++---
 1 file changed, 437 insertions(+), 54 deletions(-)
Signature · 1 line
2.35.1