Skip to content

staging: pi433: validate min/max bit rate settings

Paulo Miguel Almeida linux-staging lkml llvm oe-kbuild-all 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 3 repliesIn review
  2. v23 patches 3 repliesSuperseded
  3. v13 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: pi433: fix validation for min bit rate supported by the devicedrivers/staging/pi433/rf69.c+1 -30 replies
2/3staging: pi433: change order in which driver config the rf69 chipdrivers/staging/pi433/pi433_if.c+4 -40 replies
3/3staging: pi433: validate max bit_rate based on modulation useddrivers/staging/pi433/TODO drivers/staging/pi433/rf69.c+11 -10 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDan Carpenter
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] staging: pi433: validate min/max bit rate settings

RF69 chip supports different bit rate settings depending on which frequency modulation is used. Failing to correctly validate bit rate can lead to a silent failure and cause packets not to be read/sent.

This series change the order in which the rf69 chip is configured and add max bit rate validation.

Patch dependency:

This series depend on these patches as they change the same set of files:

- https://lore.kernel.org/lkml/[email protected]/
- https://lore.kernel.org/lkml/[email protected]/

Changelog:

v3: revert bitrate variable data type change. Req: Dan Carpenter
v2: change bitrate variable type to u32 as pointed by kernel test bot
v1: https://lore.kernel.org/lkml/[email protected]/

Paulo Miguel Almeida (3):
staging: pi433: fix validation for min bit rate supported by the
device
staging: pi433: change order in which driver config the rf69 chip
staging: pi433: validate max bit_rate based on modulation used

 drivers/staging/pi433/TODO       |  2 ++
 drivers/staging/pi433/pi433_if.c |  8 ++++----
 drivers/staging/pi433/rf69.c     | 12 +++++++++---
 3 files changed, 15 insertions(+), 7 deletions(-)
Signature · 1 line
2.25.4