Skip to content

EDAC/ghes: refactor memory error reporting to avoid code duplication

Shuai Xue linux-edac linux-efi lkml 6 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 5 repliesApplied
  2. v62 patches 3 repliesSuperseded
  3. v52 patches 6 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v42 patches2 repliesSuperseded
v3 posting 2/22 patches6 repliesSuperseded
v3 posting 1/22 patches0 repliesSuperseded

Changes in v7 from the cover letter

- Rework patch 02 by Borislav Petkov
- add patch 03 to improve format
- Link: https://lore.kernel.org/r/[email protected]

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/3efi/cper: add cper_mem_err_status_str to decode error descriptiondrivers/firmware/efi/cper.c include/linux/cper.h+30 -12 replies
2/3EDAC/ghes: Unify CPER memory error location reportingdrivers/edac/Kconfig drivers/edac/ghes_edac.c drivers/firmware/efi/cper.c +1 more+42 -1650 replies
3/3efi/cper: reformat CPER memory error location to more readabledrivers/firmware/efi/cper.c+15 -150 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchArd Biesheuvel
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/3] EDAC/ghes: refactor memory error reporting to avoid code duplication

ghes_edac_report_mem_error() in ghes_edac.c is a Long Method and have Duplicated Code with cper_mem_err_location(), cper_dimm_err_location(), and cper_mem_err_type_str() in drivers/firmware/efi/cper.c. In addition, the cper_print_mem() in drivers/firmware/efi/cper.c only reports the error status and misses its description.

This patch set is to refactor ghes_edac_report_mem_error with:

- Patch 01 is to wrap up error status decoding logics and reuse it in

    cper_print_mem().

- Patch 02 is to introduces cper_*(), into ghes_edac_report_mem_error(), this can avoid bunch of duplicate code lines;
- Patch 03 is to improve report format

Changes since v6:
- Rework patch 02 by Borislav Petkov
- add patch 03 to improve format
- Link: https://lore.kernel.org/r/[email protected]

Changes since v5:
- Delete change summary in commit log
- Link: https://lore.kernel.org/all/[email protected]/
- Thanks Borislav Petkov for review comments.

Changes since v4:
- Fix alignment and format problem
- Link: https://lore.kernel.org/all/[email protected]/

Changes since v3:

- make cper_mem_err_status_str table a lot more compact
- Fix alignment and format problem
- Link: https://lore.kernel.org/all/[email protected]/

Changes since v2:

- delete the unified patch
- adjusted the order of patches
- Link: https://lore.kernel.org/all/[email protected]/

Changes since v1:

- add a new patch to unify ghes and cper before removing duplication.
- document the changes in patch description
- add EXPORT_SYMBOL_GPL()s for cper_*()
- document and the dependency and add UEFI_CPER dependency explicitly
- Link: https://lore.kernel.org/all/[email protected]/

Shuai Xue (3):
efi/cper: add cper_mem_err_status_str to decode error description EDAC/ghes: Unify CPER memory error location reporting efi/cper: reformat CPER memory error location to more readable

 drivers/edac/Kconfig        |   1 +
 drivers/edac/ghes_edac.c    | 200 +++++++-----------------------------
 drivers/firmware/efi/cper.c |  64 ++++++++----
 include/linux/cper.h        |   3 +
 4 files changed, 87 insertions(+), 181 deletions(-)
Signature · 1 line
2.20.1.12.g72788fdb