Skip to content

btrfs-progs: fsck: detect obviously invalid metadata backref level

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs-progs: check/lowmem: fix crash when METADATA_ITEM has invalid levelcheck/mode-lowmem.c+11 -11 reply
2/3btrfs: check/original: reject bad metadata backref with invalid levelcheck/main.c+19 -02 replies
3/3btrfs-progs: tests/fsck: add test image with invalid metadata backref leveltests/fsck-tests/053-bad-metadata-level/default.img.xz tests/fsck-tests/053-bad-metadata-level/test.sh+19 -00 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchSu Yue
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] btrfs-progs: fsck: detect obviously invalid metadata backref level

There is a report that kernel tree-checker rejects a tree block of extent tree, as it contains an obvious corrupted level (which is an obvious bit flip).

But btrfs check, at least original mode, doesn't detect it at all. While with my crafted image, lowmem mode would just crash due to the large level value overflowing path->nodes[level].

Lowmem is enhanced to reject such level, and the existing code will verify the level and report errors.

Original mode is more tricky, as it doesn't have level check at all. I don't have a good idea to implement full level check at original mode, so here I just introduced a basic check for tree level and reject it.

Finally introduce a test case for this.

Qu Wenruo (3):
btrfs-progs: check/lowmem: fix crash when METADATA_ITEM has invalid
level
btrfs: check/original: reject bad metadata backref with invalid level
btrfs-progs: tests/fsck: add test image with invalid metadata backref
level

 check/main.c                                  |  19 ++++++++++++++++++
 check/mode-lowmem.c                           |  12 ++++++++++-
 .../053-bad-metadata-level/default.img.xz     | Bin 0 -> 2084 bytes
 .../fsck-tests/053-bad-metadata-level/test.sh |  19 ++++++++++++++++++
 4 files changed, 49 insertions(+), 1 deletion(-)
 create mode 100644 tests/fsck-tests/053-bad-metadata-level/default.img.xz
 create mode 100755 tests/fsck-tests/053-bad-metadata-level/test.sh
Signature · 1 line
2.34.1