Skip to content

misc brcmfmac fixes (M1/T2 series spin-off)

Hector Martin linux-acpi linux-devicetree linux-wireless lkml netdev stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 11 repliesIn review
  2. v39 patches 27 repliesSuperseded

Changes in v4 from the cover letter

- Sprinkled Cc: stable tags on all the commits that fix real bugs
- Added review tags
- Removed error message on alloc failure path in #7

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error pathdrivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c+2 -02 replies
2/9brcmfmac: firmware: Allocate space for default boardrev in nvramdrivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c+2 -01 reply
3/9brcmfmac: firmware: Do not crash on a NULL board_typedrivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c+3 -05 replies
4/9brcmfmac: pcie: Declare missing firmware files in pcie.cdrivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c+7 -10 replies
5/9brcmfmac: pcie: Replace brcmf_pcie_copy_mem_todev with memcpy_toiodrivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c+4 -440 replies
6/9brcmfmac: pcie: Fix crashes due to early IRQsdrivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c+13 -31 reply
7/9brcmfmac: of: Use devm_kstrdup for board_type & check for errorsdrivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c+5 -21 reply
8/9brcmfmac: fwil: Constify iovar name argumentsdrivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.c drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h+31 -310 replies
9/9brcmfmac: pcie: Read the console on init and shutdowndrivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c+4 -01 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchLinus WalleijArend van SprielDmitry OsipenkoAndy Shevchenko
1/9R-b R-b R-b
2/9R-b R-b
3/9R-b R-b
4/9R-b R-b
5/9R-b R-b R-b
6/9R-b R-b R-b
7/9R-b R-b
8/9R-b R-b R-b
9/9R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/9] misc brcmfmac fixes (M1/T2 series spin-off)

Hi everyone,

This series contains just the fixes / misc improvements from the previously submitted series:

brcmfmac: Support Apple T2 and M1 platforms

Patches 8-9 aren't strictly bugfixes but rather just general improvements; they can be safely skipped, although patch 8 will be a dependency of the subsequent series to avoid a compile warning.

Changes since v3:
- Sprinkled Cc: stable tags on all the commits that fix real bugs
- Added review tags
- Removed error message on alloc failure path in #7

Hector Martin (9):
brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path
brcmfmac: firmware: Allocate space for default boardrev in nvram
brcmfmac: firmware: Do not crash on a NULL board_type
brcmfmac: pcie: Declare missing firmware files in pcie.c
brcmfmac: pcie: Replace brcmf_pcie_copy_mem_todev with memcpy_toio
brcmfmac: pcie: Fix crashes due to early IRQs
brcmfmac: of: Use devm_kstrdup for board_type & check for errors
brcmfmac: fwil: Constify iovar name arguments
brcmfmac: pcie: Read the console on init and shutdown

 .../broadcom/brcm80211/brcmfmac/firmware.c    |  5 ++
 .../broadcom/brcm80211/brcmfmac/fwil.c        | 34 ++++----
 .../broadcom/brcm80211/brcmfmac/fwil.h        | 28 +++----
 .../wireless/broadcom/brcm80211/brcmfmac/of.c |  7 +-
 .../broadcom/brcm80211/brcmfmac/pcie.c        | 77 ++++++++-----------
 .../broadcom/brcm80211/brcmfmac/sdio.c        |  1 -
 6 files changed, 71 insertions(+), 81 deletions(-)
Signature · 1 line
2.33.0