Skip to content

drm/i915: Fix bandwith related cdclk calculations

Ville Syrjala intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 6 repliesIn review
  2. v115 patches 16 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9drm/i915: Tweak plane ddb allocation trackingdrivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_display.c +3 more+74 -910 replies
2/9drm/i915: Split plane data_rate into data_rate+data_rate_ydrivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_atomic_plane.h drivers/gpu/drm/i915/display/intel_bw.c +2 more+42 -380 replies
3/9drm/i915: Pre-calculate plane relative data ratedrivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_types.h +1 more+108 -1540 replies
4/9drm/i915: Remove total[] and uv_total[] from ddb allocationdrivers/gpu/drm/i915/intel_pm.c+62 -600 replies
5/9drm/i915: Nuke intel_bw_calc_min_cdclk()drivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_bw.h drivers/gpu/drm/i915/display/intel_cdclk.c+5 -760 replies
6/9drm/i915: Round up when calculating display bandwidth requirementsdrivers/gpu/drm/i915/display/intel_bw.c+2 -21 reply
7/9drm/i915: Properly write lock bw_state when it changesdrivers/gpu/drm/i915/display/intel_bw.c+23 -11 reply
8/9drm/i915: Fix DBUF bandwidth vs. cdclk handlingdrivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_bw.h drivers/gpu/drm/i915/display/intel_cdclk.c +1 more+148 -903 replies
9/9drm/i915: Add "maximum pipe read bandwidth" checksdrivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_bw.h+32 -51 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchStanislav Lisovskiy
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Intel-gfx] [PATCH v2 0/9] drm/i915: Fix bandwith related cdclk calculations

From: Ville Syrjälä <[email protected]>

Fix up the dbuf bandwidth cdclk calculations to match the spec, and also implement the cdclk based pipe max bandwidth limit.

TODO: intel_bw contains two orthogonal things (qgv vs. cdclk).
We should probably just split it into two parts to life less confusing. But as usual naming is hard so I didn't go for that yet...

v2: Rebased due to the async flip wm0/ddb stuff

Ville Syrjälä (9):
drm/i915: Tweak plane ddb allocation tracking
drm/i915: Split plane data_rate into data_rate+data_rate_y drm/i915: Pre-calculate plane relative data rate drm/i915: Remove total[] and uv_total[] from ddb allocation drm/i915: Nuke intel_bw_calc_min_cdclk()
drm/i915: Round up when calculating display bandwidth requirements drm/i915: Properly write lock bw_state when it changes drm/i915: Fix DBUF bandwidth vs. cdclk handling drm/i915: Add "maximum pipe read bandwidth" checks

 .../gpu/drm/i915/display/intel_atomic_plane.c | 120 ++++--
 .../gpu/drm/i915/display/intel_atomic_plane.h |   3 +-
 drivers/gpu/drm/i915/display/intel_bw.c       | 254 ++++++++-----
 drivers/gpu/drm/i915/display/intel_bw.h       |  12 +-
 drivers/gpu/drm/i915/display/intel_cdclk.c    |  96 ++---
 drivers/gpu/drm/i915/display/intel_cdclk.h    |   2 +
 drivers/gpu/drm/i915/display/intel_display.c  |  17 +-
 .../drm/i915/display/intel_display_debugfs.c  |   4 +-
 .../drm/i915/display/intel_display_types.h    |  16 +-
 drivers/gpu/drm/i915/intel_pm.c               | 359 ++++++------------
 10 files changed, 431 insertions(+), 452 deletions(-)
Signature · 1 line
2.34.1