Skip to content

RFC KVM: SVM: Defer page pinning for SEV guests

Nikunj A Dadhania kvm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 26 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6KVM: x86/mmu: Add hook to pin PFNs on demand in MMUarch/x86/include/asm/kvm-x86-ops.h arch/x86/include/asm/kvm_host.h arch/x86/kvm/mmu/mmu.c +1 more+13 -00 replies
2/6KVM: SVM: Add pinning metadata in the arch memslotarch/x86/include/asm/kvm-x86-ops.h arch/x86/include/asm/kvm_host.h arch/x86/kvm/svm/sev.c +3 more+77 -10 replies
3/6KVM: SVM: Implement demand page pinningarch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm.h+81 -13114 replies
4/6KVM: x86/mmu: Introduce kvm_mmu_map_tdp_page() for use by SEV/TDXarch/x86/kvm/mmu.h arch/x86/kvm/mmu/mmu.c+41 -00 replies
5/6KVM: SEV: Carve out routine for allocation of pagesarch/x86/kvm/svm/sev.c+28 -160 replies
6/6KVM: SVM: Pin SEV pages in MMU during sev_launch_update_data()arch/x86/kvm/svm/sev.c+119 -310 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/6] KVM: SVM: Defer page pinning for SEV guests

SEV guest requires the guest's pages to be pinned in host physical memory as migration of encrypted pages is not supported. The memory encryption scheme uses the physical address of the memory being encrypted. If guest pages are moved by the host, content decrypted in the guest would be incorrect thereby corrupting guest's memory.

For SEV/SEV-ES guests, the hypervisor doesn't know which pages are encrypted and when the guest is done using those pages. Hypervisor should treat all the guest pages as encrypted until the guest is destroyed.

Actual pinning management is handled by vendor code via new kvm_x86_ops hooks. MMU calls in to vendor code to pin the page on demand. Metadata of the pinning is stored in architecture specific memslot area. During the memslot freeing path guest pages are unpinned.

Initially started with [1], where the idea was to store the pinning information using the software bit in the SPTE to track the pinned page. That is not feasible for the following reason:

The pinned SPTE information gets stored in the shadow pages(SP). The way current MMU is designed, the full MMU context gets dropped multiple number of times even when CR0.WP bit gets flipped. Due to dropping of the MMU context (aka roots), there is a huge amount of SP alloc/remove churn. Pinned information stored in the SP gets lost during the dropping of the root and subsequent SP at the child levels. Without this information making decisions about re-pinnning page or unpinning during the guest shutdown will not be possible

[1] https://patchwork.kernel.org/project/kvm/cover/[email protected]/

Nikunj A Dadhania (4):
KVM: x86/mmu: Add hook to pin PFNs on demand in MMU
KVM: SVM: Add pinning metadata in the arch memslot
KVM: SVM: Implement demand page pinning
KVM: SEV: Carve out routine for allocation of pages

Sean Christopherson (2):
KVM: x86/mmu: Introduce kvm_mmu_map_tdp_page() for use by SEV/TDX
KVM: SVM: Pin SEV pages in MMU during sev_launch_update_data()

 arch/x86/include/asm/kvm-x86-ops.h |   3 +
 arch/x86/include/asm/kvm_host.h    |   9 +
 arch/x86/kvm/mmu.h                 |   3 +
 arch/x86/kvm/mmu/mmu.c             |  41 +++
 arch/x86/kvm/mmu/tdp_mmu.c         |   7 +
 arch/x86/kvm/svm/sev.c             | 423 +++++++++++++++++++----------
 arch/x86/kvm/svm/svm.c             |   4 +
 arch/x86/kvm/svm/svm.h             |   9 +-
 arch/x86/kvm/x86.c                 |  11 +-
 9 files changed, 359 insertions(+), 151 deletions(-)
Signature · 1 line
2.32.0