Skip to content

virtio-mem: Handle preallocation with migration

David Hildenbrand qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest8 patches 13 repliesIn review
  2. v3 posting 2/28 patches 28 repliesSuperseded
  3. v3 posting 1/26 patches 20 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v22 patches1 replySuperseded
v12 patches4 repliesSuperseded

Changes in v5 from the cover letter

- "migration/savevm: Move more savevm handling into vmstate_save()" -- Extended patch description regarding tracing
- "migration/savevm: Prepare vmdesc json writer in qemu_savevm_state_setup()"
-- Move freeing to migrate_fd_cleanup()
- "migration/savevm: Allow immutable device state to be migrated early (i.e., before RAM)"
-- "immutable" -> "early_setup"
-- Extend comment
- Added some RBs (thanks!)

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8migration/savevm: Move more savevm handling into vmstate_save()migration/savevm.c+37 -421 reply
2/8migration/savevm: Prepare vmdesc json writer in qemu_savevm_state_setup()migration/migration.c migration/migration.h migration/savevm.c+18 -61 reply
3/8migration/savevm: Allow immutable device state to be migrated early (i.e., before RAM)include/migration/vmstate.h migration/savevm.c+29 -11 reply
4/8migration/vmstate: Introduce VMSTATE_WITH_TMP_TEST() and VMSTATE_BITMAP_TEST()include/migration/vmstate.h+10 -21 reply
5/8migration/ram: Factor out check for advised postcopyinclude/migration/misc.h migration/migration.c migration/ram.c+11 -81 reply
6/8virtio-mem: Fail if a memory backend with "prealloc=on" is specifiedhw/virtio/virtio-mem.c+6 -01 reply
7/8virtio-mem: Migrate immutable properties earlyhw/core/machine.c hw/virtio/virtio-mem.c include/hw/virtio/virtio-mem.h+60 -31 reply
8/8virtio-mem: Proper support for preallocation with migrationhw/virtio/virtio-mem.c+87 -01 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDr. David Alan GilbertMichal PrivoznikPeter XuMichael S. TsirkinJuan Quintela
SeriesR-b R-b
1/8R-b
2/8R-b R-b
3/8R-b
4/8R-b R-b
5/8R-b
6/8R-b T-b R-b
7/8R-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/8] virtio-mem: Handle preallocation with migration

While playing with migration of virtio-mem with an ordinary file backing, I realized that migration and prealloc doesn't currently work as expected for virtio-mem. Further, Jing Qi reported that setup issues (insufficient huge pages on the destination) result in QEMU getting killed with SIGBUS instead of failing gracefully.

In contrast to ordinary memory backend preallocation, virtio-mem preallocates memory before plugging blocks to the guest. Consequently, when migrating we are not actually preallocating on the destination but "only" migrate pages. Fix that be migrating the bitmap early, before any RAM content, and use that information to preallocate memory early, before migrating any RAM.

Postcopy needs some extra care, and I realized that prealloc+postcopy is shaky in general. Let's at least try to mimic what ordinary prealloc+postcopy does: temporarily allocate the memory, discard it, and cross fingers that we'll still have sufficient memory when postcopy actually tries placing pages.

Cc Dr. David Alan Gilbert <[email protected]>
Cc Juan Quintela <[email protected]>
Cc Peter Xu <[email protected]>
Cc Michael S. Tsirkin <[email protected]>
Cc Michal Privoznik <[email protected]>

v4 -> v5:
- "migration/savevm: Move more savevm handling into vmstate_save()" -- Extended patch description regarding tracing
- "migration/savevm: Prepare vmdesc json writer in qemu_savevm_state_setup()"
-- Move freeing to migrate_fd_cleanup()
- "migration/savevm: Allow immutable device state to be migrated early (i.e., before RAM)"
-- "immutable" -> "early_setup"
-- Extend comment
- Added some RBs (thanks!)

v3 -> v4:
- First 3 patches:
-- Minimze code changes and simplify
-- Save immutable device state during qemu_savevm_state_setup() -- Don't use vmsd priorities, use a new flag
-- Split it logically up
- "migration/ram: Factor out check for advised postcopy" -- Don't factor out postcopy_is_running()
- "virtio-mem: Migrate immutable properties early"
-- Adjust to changed vmsd interface
- "virtio-mem: Proper support for preallocation with migration" -- Drop sanity check in virtio_mem_post_load_early()

v2 -> v3:
- New approach/rewrite, drop RB and TB of last patch

v1 -> v2:
- Added RBs and Tested-bys
- "virtio-mem: Fail if a memory backend with "prealloc=on" is specified" -- Fail instead of warn
-- Adjust subject/description

David Hildenbrand (8):
migration/savevm: Move more savevm handling into vmstate_save() migration/savevm: Prepare vmdesc json writer in
qemu_savevm_state_setup()
migration/savevm: Allow immutable device state to be migrated early

    (i.e., before RAM)

migration/vmstate: Introduce VMSTATE_WITH_TMP_TEST() and
VMSTATE_BITMAP_TEST()
migration/ram: Factor out check for advised postcopy
virtio-mem: Fail if a memory backend with "prealloc=on" is specified
virtio-mem: Migrate immutable properties early
virtio-mem: Proper support for preallocation with migration

 hw/core/machine.c              |   4 +-
 hw/virtio/virtio-mem.c         | 144 ++++++++++++++++++++++++++++++++-
 include/hw/virtio/virtio-mem.h |   8 ++
 include/migration/misc.h       |   4 +-
 include/migration/vmstate.h    |  28 ++++++-
 migration/migration.c          |   9 +++
 migration/migration.h          |   4 +
 migration/ram.c                |   8 +-
 migration/savevm.c             | 105 +++++++++++++-----------
 9 files changed, 255 insertions(+), 59 deletions(-)
Signature · 1 line
2.39.0