RFC Allow GUI plugins to build standalone
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest2 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | kernel-shark: Add KsPluginsGUI.hpp/.cppsrc/ src/ src/ | +50 | 0 replies | |
| 2/2 | kernel-shark: Install missing headerssrc/ src/ | +15 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/2] Allow GUI plugins to build standalone
Hi Hongzhan and Jan,
I tried to build your plugin standalone and I realized that this is in fact not possible due to some missing header files. This gets fixed in the following patch-set. I also made some minor modifications in the code of your plugin and will send you this modified version of the plugin in a separate email.
Please let me know if you find this modifications useful or not?
Cheers,
Yordan
Yordan Karadzhov (VMware) (2):
kernel-shark: Add KsPluginsGUI.hpp/.cpp
kernel-shark: Install missing headers
src/CMakeLists.txt | 12 ++++++++++++ src/KsPluginsGUI.cpp | 27 +++++++++++++++++++++++++++ src/KsPluginsGUI.hpp | 22 ++++++++++++++++++++++ src/plugins/CMakeLists.txt | 4 ++++ 4 files changed, 65 insertions(+) create mode 100644 src/KsPluginsGUI.cpp create mode 100644 src/KsPluginsGUI.hpp
Signature · 1 line
2.32.0