Skip to content

fix crash by reading /proc/diskstats

Daniel Wagner linux-block lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2block: remove commented out code from diskstats_showblock/genhd.c+0 -82 replies
2/2block: hold queue lock while iterating in diskstats_showblock/genhd.c+3 -012 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchHannes Reinecke
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] fix crash by reading /proc/diskstats

During failover nvme-tcp tests in a HA setup a crash orccured. iostat was running in the background while the test was executed.

I am not sure if the fix is correct. I am unsure if using blk_queue_enter() is the right thing. But when starring at the code snipped I saw in older version blk_queue_enter() was used but got evenutally replaced by the rcu_read_lock() as far I understand at the moment... So any tip here would be highly appreciated.

Daniel

Daniel Wagner (2):
block: remove commented out code from diskstats_show
block: hold queue lock while iterating in diskstats_show

 block/genhd.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
Signature · 1 line
2.29.2