Skip to content

kvm: selftests: aarch64: some fixes for vgic_irq

Ricardo Koller kvm kvmarm 2 versions – Applied

Status from this message: Applied to next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 6 repliesApplied
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- adding 3 more fixes: 2, 3, 5 above. (Reiji)
- corrected the comments in 4 above. (Andrew)
- dded drjones@ reviewed-by tag.

[0] https://lore.kernel.org/kvmarm/[email protected]/

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5kvm: selftests: aarch64: fix assert in gicv3_access_regtools/testing/selftests/kvm/lib/aarch64/gic_v3.c+1 -11 reply
2/5kvm: selftests: aarch64: pass vgic_irq guest args as a pointertools/testing/selftests/kvm/aarch64/vgic_irq.c+16 -131 reply
3/5kvm: selftests: aarch64: fix the failure check in kvm_set_gsi_routing_irqchip_checktools/testing/selftests/kvm/aarch64/vgic_irq.c+2 -20 replies
4/5kvm: selftests: aarch64: fix some vgic related commentstools/testing/selftests/kvm/aarch64/vgic_irq.c tools/testing/selftests/kvm/lib/aarch64/gic_v3.c tools/testing/selftests/kvm/lib/aarch64/vgic.c+16 -92 replies
5/5kvm: selftests: aarch64: use a tighter assert in vgic_poke_irq()tools/testing/selftests/kvm/lib/aarch64/vgic.c+3 -31 reply

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchAndrew Jones
1/5R-b
2/5R-b
3/5
4/5R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] kvm: selftests: aarch64: some fixes for vgic_irq

Reiji discovered multiple issues with the vgic_irq series [0]:
1. there's an assert that needs fixing.
2. some guest arguments are not set correctly.
3. the failure test in kvm_set_gsi_routing_irqchip_check is wrong.
4. there are lots of comments that use the wrong formatting.
5. vgic_poke_irq() could use a tighter assert check.

The first 3 issues above are critical, the last 2 would be nice to have. I haven't hit the failed assert (1.), but just by chance: my compiler is initializing the respective local variable to 0. The second issue (2.) leads to not testing one of the injection methods (irqfd). The third issue could be hit if we tested more intids.

v1 -> v2:
- adding 3 more fixes: 2, 3, 5 above. (Reiji)
- corrected the comments in 4 above. (Andrew)
- dded drjones@ reviewed-by tag.

[0] https://lore.kernel.org/kvmarm/[email protected]/

Ricardo Koller (5):
kvm: selftests: aarch64: fix assert in gicv3_access_reg
kvm: selftests: aarch64: pass vgic_irq guest args as a pointer
kvm: selftests: aarch64: fix the failure check in
kvm_set_gsi_routing_irqchip_check
kvm: selftests: aarch64: fix some vgic related comments
kvm: selftests: aarch64: use a tighter assert in vgic_poke_irq()

 .../testing/selftests/kvm/aarch64/vgic_irq.c  | 45 +++++++++++--------
 .../selftests/kvm/lib/aarch64/gic_v3.c        | 12 ++---
 .../testing/selftests/kvm/lib/aarch64/vgic.c  |  9 ++--
 3 files changed, 38 insertions(+), 28 deletions(-)
Signature · 1 line
2.35.0.rc0.227.g00780c9af4-goog