Skip to content

leds: start removing obsolete/useless enum

Luiz Sampaio alsa-devel b43-dev dri-devel linux-arm-kernel linux-bluetooth linux-fbdev linux-hwmon linux-iio linux-input linux-leds linux-media linux-mediatek linux-mmc linux-pm linux-usb linux-wireless linuxppc-dev lkml netdev netfilter-devel nouveau platform-driver-x86 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest31 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/31gpu: nouveau: nouveau_led: changing LED_FULL to actual valuedrivers/gpu/drm/nouveau/nouveau_led.c+2 -21 reply
2/31hid: changing LED_* from enum led_brightness to actual valuedrivers/hid/hid-bigbenff.c drivers/hid/hid-elan.c drivers/hid/hid-lenovo.c +9 more+38 -380 replies
3/31hwmon: pmbus: changing LED_* from enum led_brightness to actual valuedrivers/hwmon/pmbus/ibm-cffps.c+4 -41 reply
4/31iio: light: cm3605: changing LED_* from enum led_brightness to actual valuedrivers/iio/light/cm3605.c+5 -51 reply
5/31input: keyboard: changing LED_* from enum led_brightness to actual valuedrivers/input/keyboard/cap11xx.c drivers/input/keyboard/qt2160.c drivers/input/keyboard/tm2-touchkey.c+10 -100 replies
6/31input: misc: changing LED_* from enum led_brightness to actual valuedrivers/input/misc/apanel.c drivers/input/misc/ims-pcu.c drivers/input/misc/wistron_btns.c+7 -70 replies
7/31input: touchscreen: changing LED_* from enum led_brightness to actual valuedrivers/input/touchscreen/stmfts.c+2 -20 replies
8/31leds: changing LED_* from enum led_brightness to actual valuedrivers/leds/blink/leds-lgm-sso.c drivers/leds/flash/leds-ktd2692.c drivers/leds/flash/leds-lm3601x.c +71 more+217 -2170 replies
9/31macintosh: changing LED_* from enum led_brightness to actual valuedrivers/macintosh/via-pmu-led.c+1 -10 replies
10/31media: radio: changing LED_* from enum led_brightness to actual valuedrivers/media/radio/radio-shark.c drivers/media/radio/radio-shark2.c+5 -50 replies
11/31media: rc: changing LED_* from enum led_brightness to actual valuedrivers/media/rc/rc-main.c drivers/media/rc/redrat3.c drivers/media/rc/ttusbir.c +1 more+9 -91 reply
12/31media: v4l2-core: changing LED_* from enum led_brightness to actual valuedrivers/media/v4l2-core/v4l2-flash-led-class.c+2 -22 replies
13/31mmc: changing LED_* from enum led_brightness to actual valuedrivers/mmc/core/core.c drivers/mmc/host/rtsx_usb_sdmmc.c drivers/mmc/host/sdhci.c+6 -60 replies
14/31net: wireless: ath: changing LED_* from enum led_brightness to actual valuedrivers/net/wireless/ath/ath5k/led.c drivers/net/wireless/ath/ath9k/gpio.c drivers/net/wireless/ath/ath9k/htc_drv_gpio.c+5 -50 replies
15/31net: wireless: atmel: changing LED_* from enum led_brightness to actual valuedrivers/net/wireless/atmel/at76c50x-usb.c+2 -20 replies
16/31net: broadcom: changing LED_* from enum led_brightness to actual valuedrivers/net/wireless/broadcom/b43/leds.c drivers/net/wireless/broadcom/b43legacy/leds.c+2 -21 reply
17/31net: intersil: changing LED_* from enum led_brightness to actual valuedrivers/net/wireless/intersil/p54/led.c+1 -10 replies
18/31net: wireless: ralink: changing LED_* from enum led_brightness to actual valuedrivers/net/wireless/ralink/rt2x00/rt2400pci.c drivers/net/wireless/ralink/rt2x00/rt2500pci.c drivers/net/wireless/ralink/rt2x00/rt2500usb.c +4 more+17 -170 replies
19/31net: realtek: changing LED_* from enum led_brightness to actual valuedrivers/net/wireless/realtek/rtl818x/rtl8187/leds.c+2 -20 replies
20/31platform: x86: changing LED_* from enum led_brightness to actual valuedrivers/platform/x86/acer-wmi.c drivers/platform/x86/asus-wireless.c drivers/platform/x86/dell/dell-laptop.c +7 more+55 -552 replies
21/31power: supply: changing LED_* from enum led_brightness to actual valuedrivers/power/supply/power_supply_leds.c+13 -130 replies
22/31tty: vt: changing LED_* from enum led_brightness to actual valuedrivers/tty/vt/keyboard.c+2 -21 reply
23/31usb: core: changing LED_* from enum led_brightness to actual valuedrivers/usb/core/ledtrig-usbport.c+3 -31 reply
24/31video: backlight: changing LED_* from enum led_brightness to actual valuedrivers/video/backlight/adp8860_bl.c drivers/video/backlight/adp8870_bl.c drivers/video/backlight/led_bl.c+5 -54 replies
25/31include: linux: leds: changing LED_* from enum led_brightness to actual valueinclude/linux/leds.h+1 -10 replies
26/31net: bluetooth: changing LED_* from enum led_brightness to actual valuenet/bluetooth/leds.c+3 -31 reply
27/31net: mac80211 : changing LED_* from enum led_brightness to actual valuenet/mac80211/led.c+5 -51 reply
28/31net: netfilter: changing LED_* from enum led_brightness to actual valuenet/netfilter/xt_LED.c+3 -30 replies
29/31net: rfkill: changing LED_* from enum led_brightness to actual valuenet/rfkill/core.c+4 -40 replies
30/31sound: core: changing LED_* from enum led_brightness to actual valuesound/core/control_led.c+1 -10 replies
31/31sound: soc: sof: changing LED_* from enum led_brightness to actual valuesound/soc/sof/control.c+2 -21 reply

Reviews trailers per patch

3 of 31 patches have a Reviewed-by or Acked-by.

PatchDaniel ThompsonJonathan WoitheHans de GoedeSakari Ailus
1/31
2/31
3/31
4/31
5/31
6/31
7/31
8/31
9/31
10/31
11/31
12/31A-b
13/31
14/31
15/31
16/31
17/31
18/31
19/31
20/31A-b A-b
21/31
22/31
23/31
24/31R-b
25/31
26/31
27/31
28/31
29/31
30/31
31/31

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/31] leds: start removing obsolete/useless enum

This series of patches aims to replace the enum led_brightness in include/linux/leds.h with unsigned int, as requested in the TODO file in the drivers/leds folder. The first step is to change the old definitions LED_OFF, LED_ON, LED_HALF and LED_FULL with the values.

This was done using find/grep/sed and later I did a review of the patch to check that everything was right. A compilation using allmodconfig was done to test that nothing broke.

I have more patches coming that will replace all the enum led_brightness with unsigned int, as the led class now has support for max_brightness.

Please help review this patch.

Best regards,

Luiz Sampaio (31):
gpu: nouveau: nouveau_led: changing LED_FULL to actual value
hid: changing LED_* from enum led_brightness to actual value
hwmon: pmbus: changing LED_* from enum led_brightness to actual value
iio: light: cm3605: changing LED_* from enum led_brightness to actual
value
input: keyboard: changing LED_* from enum led_brightness to actual
value
input: misc: changing LED_* from enum led_brightness to actual value
input: touchscreen: changing LED_* from enum led_brightness to actual
value
leds: changing LED_* from enum led_brightness to actual value
macintosh: changing LED_* from enum led_brightness to actual value
media: radio: changing LED_* from enum led_brightness to actual value
media: rc: changing LED_* from enum led_brightness to actual value
media: v4l2-core: changing LED_* from enum led_brightness to actual
value
mmc: changing LED_* from enum led_brightness to actual value
net: wireless: ath: changing LED_* from enum led_brightness to actual
value
net: wireless: atmel: changing LED_* from enum led_brightness to
actual value
net: broadcom: changing LED_* from enum led_brightness to actual value
net: intersil: changing LED_* from enum led_brightness to actual value
net: wireless: ralink: changing LED_* from enum led_brightness to
actual value
net: realtek: changing LED_* from enum led_brightness to actual value
platform: x86: changing LED_* from enum led_brightness to actual value
power: supply: changing LED_* from enum led_brightness to actual value
tty: vt: changing LED_* from enum led_brightness to actual value
usb: core: changing LED_* from enum led_brightness to actual value
video: backlight: changing LED_* from enum led_brightness to actual
value
include: linux: leds: changing LED_* from enum led_brightness to
actual value
net: bluetooth: changing LED_* from enum led_brightness to actual
value
net: mac80211 : changing LED_* from enum led_brightness to actual
value
net: netfilter: changing LED_* from enum led_brightness to actual
value
net: rfkill: changing LED_* from enum led_brightness to actual value
sound: core: changing LED_* from enum led_brightness to actual value
sound: soc: sof: changing LED_* from enum led_brightness to actual
value

 drivers/gpu/drm/nouveau/nouveau_led.c         |  4 +--
 drivers/hid/hid-bigbenff.c                    | 10 +++----
 drivers/hid/hid-elan.c                        |  2 +-
 drivers/hid/hid-lenovo.c                      |  2 +-
 drivers/hid/hid-lg4ff.c                       | 10 +++----
 drivers/hid/hid-picolcd_leds.c                |  6 ++--
 drivers/hid/hid-playstation.c                 |  2 +-
 drivers/hid/hid-sony.c                        |  4 +--
 drivers/hid/hid-steelseries.c                 | 14 ++++-----
 drivers/hid/hid-u2fzero.c                     |  4 +--
 drivers/hid/hid-wiimote-modules.c             |  4 +--
 drivers/hid/wacom_sys.c                       | 16 +++++-----
 drivers/hid/wacom_wac.c                       |  2 +-
 drivers/hwmon/pmbus/ibm-cffps.c               |  8 ++---
 drivers/iio/light/cm3605.c                    | 10 +++----
 drivers/input/keyboard/cap11xx.c              |  2 +-
 drivers/input/keyboard/qt2160.c               |  6 ++--
 drivers/input/keyboard/tm2-touchkey.c         | 12 ++++----
 drivers/input/misc/apanel.c                   |  4 +--
 drivers/input/misc/ims-pcu.c                  |  2 +-
 drivers/input/misc/wistron_btns.c             |  8 ++---
 drivers/input/touchscreen/stmfts.c            |  4 +--
 drivers/leds/blink/leds-lgm-sso.c             |  8 ++---
 drivers/leds/flash/leds-ktd2692.c             |  4 +--
 drivers/leds/flash/leds-lm3601x.c             | 10 +++----
 drivers/leds/flash/leds-mt6360.c              | 10 +++----
 drivers/leds/flash/leds-rt4505.c              |  8 ++---
 drivers/leds/flash/leds-rt8515.c              |  4 +--
 drivers/leds/flash/leds-sgm3140.c             |  4 +--
 drivers/leds/led-class.c                      |  6 ++--
 drivers/leds/led-core.c                       |  8 ++---
 drivers/leds/led-triggers.c                   |  4 +--
 drivers/leds/leds-adp5520.c                   |  2 +-
 drivers/leds/leds-an30259a.c                  |  8 ++---
 drivers/leds/leds-apu.c                       |  6 ++--
 drivers/leds/leds-ariel.c                     |  8 ++---
 drivers/leds/leds-asic3.c                     |  2 +-
 drivers/leds/leds-aw2013.c                    |  6 ++--
 drivers/leds/leds-bcm6328.c                   | 14 ++++-----
 drivers/leds/leds-bcm6358.c                   | 14 ++++-----
 drivers/leds/leds-bd2802.c                    | 14 ++++-----
 drivers/leds/leds-clevo-mail.c                |  6 ++--
 drivers/leds/leds-cobalt-qube.c               |  2 +-
 drivers/leds/leds-cpcap.c                     | 10 +++----
 drivers/leds/leds-da903x.c                    |  4 +--
 drivers/leds/leds-da9052.c                    |  4 +--
 drivers/leds/leds-dac124s085.c                |  2 +-
 drivers/leds/leds-el15203000.c                |  4 +--
 drivers/leds/leds-gpio.c                      |  4 +--
 drivers/leds/leds-is31fl319x.c                |  2 +-
 drivers/leds/leds-lm3530.c                    |  4 +--
 drivers/leds/leds-lm3532.c                    |  8 ++---
 drivers/leds/leds-lm3533.c                    |  4 +--
 drivers/leds/leds-lm3692x.c                   |  2 +-
 drivers/leds/leds-lm3697.c                    |  6 ++--
 drivers/leds/leds-lp3952.c                    |  4 +--
 drivers/leds/leds-lt3593.c                    |  2 +-
 drivers/leds/leds-max77650.c                  |  4 +--
 drivers/leds/leds-menf21bmc.c                 |  2 +-
 drivers/leds/leds-mlxcpld.c                   | 22 +++++++-------
 drivers/leds/leds-mlxreg.c                    | 10 +++----
 drivers/leds/leds-mt6323.c                    |  2 +-
 drivers/leds/leds-netxbig.c                   |  4 +--
 drivers/leds/leds-nic78bx.c                   |  2 +-
 drivers/leds/leds-ns2.c                       |  4 +--
 drivers/leds/leds-ot200.c                     |  2 +-
 drivers/leds/leds-pca9532.c                   |  6 ++--
 drivers/leds/leds-pca955x.c                   | 30 +++++++++----------
 drivers/leds/leds-pca963x.c                   |  4 +--
 drivers/leds/leds-pm8058.c                    |  8 ++---
 drivers/leds/leds-powernv.c                   | 12 ++++----
 drivers/leds/leds-pwm.c                       |  2 +-
 drivers/leds/leds-rb532.c                     |  2 +-
 drivers/leds/leds-regulator.c                 |  2 +-
 drivers/leds/leds-sc27xx-bltc.c               |  6 ++--
 drivers/leds/leds-spi-byte.c                  |  2 +-
 drivers/leds/leds-ss4200.c                    | 12 ++++----
 drivers/leds/leds-sunfire.c                   |  2 +-
 drivers/leds/leds-syscon.c                    |  2 +-
 drivers/leds/leds-tca6507.c                   |  8 ++---
 drivers/leds/leds-wm831x-status.c             |  8 ++---
 drivers/leds/leds-wm8350.c                    |  8 ++---
 drivers/leds/simple/simatic-ipc-leds.c        | 10 +++----
 drivers/leds/trigger/ledtrig-activity.c       |  2 +-
 drivers/leds/trigger/ledtrig-backlight.c      |  4 +--
 drivers/leds/trigger/ledtrig-camera.c         |  4 +--
 drivers/leds/trigger/ledtrig-cpu.c            |  4 +--
 drivers/leds/trigger/ledtrig-gpio.c           |  4 +--
 drivers/leds/trigger/ledtrig-heartbeat.c      |  4 +--
 drivers/leds/trigger/ledtrig-netdev.c         |  6 ++--
 drivers/leds/trigger/ledtrig-oneshot.c        |  6 ++--
 drivers/leds/trigger/ledtrig-panic.c          |  2 +-
 drivers/leds/trigger/ledtrig-pattern.c        |  2 +-
 drivers/leds/trigger/ledtrig-timer.c          |  2 +-
 drivers/leds/trigger/ledtrig-transient.c      |  6 ++--
 drivers/leds/trigger/ledtrig-tty.c            |  4 +--
 drivers/macintosh/via-pmu-led.c               |  2 +-
 drivers/media/radio/radio-shark.c             |  6 ++--
 drivers/media/radio/radio-shark2.c            |  4 +--
 drivers/media/rc/rc-main.c                    |  4 +--
 drivers/media/rc/redrat3.c                    |  4 +--
 drivers/media/rc/ttusbir.c                    |  4 +--
 drivers/media/rc/winbond-cir.c                |  6 ++--
 .../media/v4l2-core/v4l2-flash-led-class.c    |  4 +--
 drivers/mmc/core/core.c                       |  4 +--
 drivers/mmc/host/rtsx_usb_sdmmc.c             |  4 +--
 drivers/mmc/host/sdhci.c                      |  4 +--
 drivers/net/wireless/ath/ath5k/led.c          |  2 +-
 drivers/net/wireless/ath/ath9k/gpio.c         |  4 +--
 drivers/net/wireless/ath/ath9k/htc_drv_gpio.c |  4 +--
 drivers/net/wireless/atmel/at76c50x-usb.c     |  4 +--
 drivers/net/wireless/broadcom/b43/leds.c      |  2 +-
 .../net/wireless/broadcom/b43legacy/leds.c    |  2 +-
 drivers/net/wireless/intersil/p54/led.c       |  2 +-
 .../net/wireless/ralink/rt2x00/rt2400pci.c    |  2 +-
 .../net/wireless/ralink/rt2x00/rt2500pci.c    |  2 +-
 .../net/wireless/ralink/rt2x00/rt2500usb.c    |  2 +-
 .../net/wireless/ralink/rt2x00/rt2800lib.c    |  4 +--
 .../net/wireless/ralink/rt2x00/rt2x00leds.c   | 16 +++++-----
 drivers/net/wireless/ralink/rt2x00/rt61pci.c  |  4 +--
 drivers/net/wireless/ralink/rt2x00/rt73usb.c  |  4 +--
 .../wireless/realtek/rtl818x/rtl8187/leds.c   |  4 +--
 drivers/platform/x86/acer-wmi.c               |  6 ++--
 drivers/platform/x86/asus-wireless.c          |  6 ++--
 drivers/platform/x86/dell/dell-laptop.c       |  2 +-
 drivers/platform/x86/dell/dell-wmi-led.c      |  4 +--
 drivers/platform/x86/fujitsu-laptop.c         | 28 ++++++++---------
 drivers/platform/x86/lg-laptop.c              | 18 +++++------
 drivers/platform/x86/system76_acpi.c          |  4 +--
 drivers/platform/x86/thinkpad_acpi.c          | 14 ++++-----
 drivers/platform/x86/topstar-laptop.c         |  4 +--
 drivers/platform/x86/toshiba_acpi.c           | 24 +++++++--------
 drivers/power/supply/power_supply_leds.c      | 26 ++++++++--------
 drivers/tty/vt/keyboard.c                     |  4 +--
 drivers/usb/core/ledtrig-usbport.c            |  6 ++--
 drivers/video/backlight/adp8860_bl.c          |  4 +--
 drivers/video/backlight/adp8870_bl.c          |  4 +--
 drivers/video/backlight/led_bl.c              |  2 +-
 include/linux/leds.h                          |  2 +-
 net/bluetooth/leds.c                          |  6 ++--
 net/mac80211/led.c                            | 10 +++----
 net/netfilter/xt_LED.c                        |  6 ++--
 net/rfkill/core.c                             |  8 ++---
 sound/core/control_led.c                      |  2 +-
 sound/soc/sof/control.c                       |  4 +--
 145 files changed, 434 insertions(+), 434 deletions(-)
Signature · 1 line
2.34.1