Skip to content

arm_gicv3_its: Implement MOVI and MOVALL commands

Peter Maydell qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14target/arm: Log CPU index in 'Taking exception' logtarget/arm/helper.c target/arm/internals.h target/arm/m_helper.c+8 -52 replies
2/14hw/intc/arm_gicv3_its: Add tracepointshw/intc/arm_gicv3_its.c hw/intc/trace-events+19 -02 replies
3/14hw/intc/arm_gicv3: Initialise dma_as in GIC, not ITShw/intc/arm_gicv3_common.c hw/intc/arm_gicv3_its.c+5 -31 reply
4/14hw/intc/arm_gicv3_its: Don't clear GITS_CREADR when GITS_CTLR.ENABLED is sethw/intc/arm_gicv3_its.c+0 -11 reply
5/14hw/intc/arm_gicv3_its: Don't clear GITS_CWRITER on writes to GITS_CBASERhw/intc/arm_gicv3_its.c+0 -31 reply
6/14hw/intc/arm_gicv3: Honour GICD_CTLR.EnableGrp1NS for LPIshw/intc/arm_gicv3.c+1 -01 reply
7/14hw/intc/arm_gicv3_its: Sort ITS command list into numeric orderhw/intc/gicv3_internal.h+5 -52 replies
8/14hw/intc/arm_gicv3_redist: Remove unnecessary zero checkshw/intc/arm_gicv3_redist.c+3 -51 reply
9/14hw/intc/arm_gicv3: Set GICR_CTLR.CES if LPIs are supportedhw/intc/arm_gicv3_common.c hw/intc/gicv3_internal.h+5 -01 reply
10/14hw/intc/arm_gicv3_its: Provide read accessor for translation_opshw/intc/arm_gicv3_its.c+13 -02 replies
11/14hw/intc/arm_gicv3_its: Make GITS_BASER<n> RAZ/WI for unimplemented registershw/intc/arm_gicv3_its.c+8 -01 reply
12/14hw/intc/arm_gicv3_its: Check table bounds against correct limithw/intc/arm_gicv3_its.c include/hw/intc/arm_gicv3_its_common.h+9 -101 reply
13/14hw/intc/arm_gicv3_its: Implement MOVALLhw/intc/arm_gicv3_its.c hw/intc/arm_gicv3_redist.c hw/intc/gicv3_internal.h+125 -01 reply
14/14hw/intc/arm_gicv3_its: Implement MOVIhw/intc/arm_gicv3_its.c hw/intc/arm_gicv3_redist.c hw/intc/gicv3_internal.h+215 -01 reply

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéRichard Henderson
1/14R-b R-b
2/14R-b R-b
3/14R-b
4/14R-b
5/14R-b
6/14R-b
7/14R-b R-b
8/14R-b
9/14R-b
10/14R-b R-b
11/14R-b
12/14R-b
13/14R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/14] arm_gicv3_its: Implement MOVI and MOVALL commands

I noticed while working on the new-in-GICv4 ITS commands that we'd forgotten to implement the GICv3 MOVI and MOVALL commands. These move interrupts from one redistributor to another; Linux doesn't use MOVALL but does use MOVI if it wants to power down a CPU (when it needs to migrate interrupts formerly targeting that CPU to a different one).

This patchseries starts with a couple of patches that I found useful to improve the debug logging when I was writing this. It then has a collection of fixes for various minor bugs that I noticed while I was in the code (including yet another fix to the table lookup bounds checking...). Finally the last two patches implement the two new commands.

thanks
-- PMM

Peter Maydell (14):
target/arm: Log CPU index in 'Taking exception' log hw/intc/arm_gicv3_its: Add tracepoints
hw/intc/arm_gicv3: Initialise dma_as in GIC, not ITS hw/intc/arm_gicv3_its: Don't clear GITS_CREADR when GITS_CTLR.ENABLED
is set
hw/intc/arm_gicv3_its: Don't clear GITS_CWRITER on writes to
GITS_CBASER
hw/intc/arm_gicv3: Honour GICD_CTLR.EnableGrp1NS for LPIs hw/intc/arm_gicv3_its: Sort ITS command list into numeric order hw/intc/arm_gicv3_redist: Remove unnecessary zero checks hw/intc/arm_gicv3: Set GICR_CTLR.CES if LPIs are supported hw/intc/arm_gicv3_its: Provide read accessor for translation_ops hw/intc/arm_gicv3_its: Make GITS_BASER<n> RAZ/WI for unimplemented
registers
hw/intc/arm_gicv3_its: Check table bounds against correct limit hw/intc/arm_gicv3_its: Implement MOVALL hw/intc/arm_gicv3_its: Implement MOVI

 hw/intc/gicv3_internal.h               |  43 ++++-
 include/hw/intc/arm_gicv3_its_common.h |   1 -
 target/arm/internals.h                 |   2 +-
 hw/intc/arm_gicv3.c                    |   1 +
 hw/intc/arm_gicv3_common.c             |   9 +
 hw/intc/arm_gicv3_its.c                | 258 +++++++++++++++++++++++--
 hw/intc/arm_gicv3_redist.c             | 115 ++++++++++-
 target/arm/helper.c                    |   9 +-
 target/arm/m_helper.c                  |   2 +-
 hw/intc/trace-events                   |   8 +
 10 files changed, 416 insertions(+), 32 deletions(-)
Signature · 1 line
2.25.1