Skip to content

sysfb: Fix memory-region management

Thomas Zimmermann dri-devel linux-fbdev stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5fbdev: Hot-unplug firmware fb devices on forced removaldrivers/video/fbdev/core/fbmem.c include/linux/fb.h+27 -35 replies
2/5drivers/firmware: Don't mark as busy the simple-framebuffer IO resourcedrivers/firmware/sysfb_simplefb.c+1 -11 reply
3/5drm/simpledrm: Request memory region in driverdrivers/gpu/drm/tiny/simpledrm.c+15 -53 replies
4/5fbdev/simplefb: Request memory region in driverdrivers/video/fbdev/simplefb.c+42 -171 reply
5/5drm: Add TODO item for requesting memory regionsDocumentation/gpu/todo.rst+15 -01 reply

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchJavier Martinez CanillasZack Rusin
1/5R-b R-b
2/5R-b
3/5R-b
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] sysfb: Fix memory-region management

Request framebuffer memory in simpledrm and simplefb. Do a hot-unplug operation when removing fbdev firmware drivers.

After being unloaded by a hardware driver, simplefb leaves behind the firmware framebuffer's platform device. This prevents other drivers from acquiring the memory as reported at [1].

Patch 1 changes the removal code of remove_conflicting_framebuffers() to remove the underlying device and the rsp memory region.

Patches 2 to 4 update sysfb and its drivers. The sysfb code does no longer mark the framebuffer memory with IORESOURCE_BUSY. Instead, the device drivers acquire the memory when they probe the device.

Patch 5 adds a todo item to acquire memory regions in all DRM drivers.

Tested with simpledrm and simplefb.

[1] https://lore.kernel.org/dri-devel/[email protected]/

Javier Martinez Canillas (1):
drivers/firmware: Don't mark as busy the simple-framebuffer IO
resource

Thomas Zimmermann (4):
fbdev: Hot-unplug firmware fb devices on forced removal drm/simpledrm: Request memory region in driver fbdev/simplefb: Request memory region in driver
drm: Add TODO item for requesting memory regions

 Documentation/gpu/todo.rst        | 15 ++++++++
 drivers/firmware/sysfb_simplefb.c |  2 +-
 drivers/gpu/drm/tiny/simpledrm.c  | 20 ++++++++---
 drivers/video/fbdev/core/fbmem.c  | 29 +++++++++++++--
 drivers/video/fbdev/simplefb.c    | 59 ++++++++++++++++++++++---------
 include/linux/fb.h                |  1 +
 6 files changed, 100 insertions(+), 26 deletions(-)

base-commit: 0bb81b5d6db5f689b67f9d8b35323235c45e890f

Signature · 1 line
2.34.1