64-bit data integrity field support
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest8 patches 23 repliesApplied
- v310 patches 36 repliesSuperseded
- v27 patches 18 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 7 patches | 5 replies | Superseded |
Changes in v4 from the cover letter
- Replaced lower_48_bits() macro with inline function, and replaced
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | block: support pi with extended metadatablock/ block/ include/ | +4 | 0 replies | |
| 2/8 | nvme: allow integrity on extended metadata formatsdrivers/ | +2 | 0 replies | |
| 3/8 | asm-generic: introduce be48 unaligned accessorsinclude/ | +26 | 4 replies | |
| 4/8 | linux/kernel: introduce lower_48_bits functioninclude/ | +9 | 1 reply | |
| 5/8 | lib: add rocksoft model crc64include/ lib/ lib/ | +70 | 3 replies | |
| 6/8 | crypto: add rocksoft 64b crc guard tag frameworkcrypto/ crypto/ crypto/ +6 more | +258 | 10 replies | |
| 7/8 | block: add pi for extended integrityblock/ block/ include/ | +215 | 1 reply | |
| 8/8 | nvme: add support for enhanced metadatadrivers/ drivers/ include/ | +188 | 1 reply |
Reviews trailers per patch
7 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig | Hannes Reinecke | Martin K. Petersen | Chaitanya Kulkarni | Arnd Bergmann | Bart Van Assche |
|---|---|---|---|---|---|---|
| 1/8 | R-b | R-b | R-b | |||
| 2/8 | R-b | R-b | R-b | |||
| 3/8 | R-b | R-b | R-b | R-b | A-b | R-b |
| 4/8 | R-b | |||||
| 5/8 | R-b | |||||
| 6/8 | ||||||
| 7/8 | R-b | |||||
| 8/8 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.
Cover letter [PATCHv4 0/8] 64-bit data integrity field support
The NVM Express protocol added enhancements to the data integrity field formats beyond the T10 defined protection information. A detailed description of the new formats can be found in the NVMe's NVM Command Set Specification, section 5.2, available at:
https://nvmexpress.org/wp-content/uploads/NVM-Command-Set-Specification-1.0b-2021.12.18-Ratified.pdf
This series implements one possible new format: the CRC64 guard with 48-bit reference tags. This does not add support for the variable "storage tag" field, or any potential hardware acceleration.
Changes since v3:
- Replaced lower_48_bits() macro with inline function, and replaced
0xffffffffffffull with the equivalent (1ull << 48) - 1
- Replaced crc64 test module with new entry in crypto/testmgr.c
- Renamed nvme_ function prefixes with ext_pi_
- Placed bit inversion within crc64 calculation rather than rely on the caller to pass in an inverted initial value. This is necessary to update the crc value when its buffer is discontiguous, or updated in chunks.
- Removed 'inline' from nvme driver's ref tag setup.
- Added Review's for unchanged patches, removed reviews for the ones that changed.
- lib/Kconfig dependency fix
- Dropped the x86_64 PCLMULQDQ accelerated calculation. This task will be completed by people more experienced in this area, so expect a follow up soon.
Keith Busch (8):
block: support pi with extended metadata
nvme: allow integrity on extended metadata formats
asm-generic: introduce be48 unaligned accessors linux/kernel: introduce lower_48_bits function
lib: add rocksoft model crc64
crypto: add rocksoft 64b crc guard tag framework
block: add pi for nvme enhanced integrity
nvme: add support for enhanced metadata
block/Kconfig | 1 + block/bio-integrity.c | 1 + block/t10-pi.c | 198 +++++++++++++++++++++++++++++++- crypto/Kconfig | 5 + crypto/Makefile | 1 + crypto/crc64_rocksoft_generic.c | 89 ++++++++++++++ crypto/testmgr.c | 7 ++ crypto/testmgr.h | 15 +++ drivers/nvme/host/core.c | 165 +++++++++++++++++++++----- drivers/nvme/host/nvme.h | 4 +- include/asm-generic/unaligned.h | 26 +++++ include/linux/blk-integrity.h | 1 + include/linux/crc64.h | 7 ++ include/linux/kernel.h | 9 ++ include/linux/nvme.h | 53 ++++++++- include/linux/t10-pi.h | 20 ++++ lib/Kconfig | 9 ++ lib/Makefile | 1 + lib/crc64-rocksoft.c | 129 +++++++++++++++++++++ lib/crc64.c | 28 +++++ lib/gen_crc64table.c | 51 ++++++-- 21 files changed, 773 insertions(+), 47 deletions(-) create mode 100644 crypto/crc64_rocksoft_generic.c create mode 100644 lib/crc64-rocksoft.c
Signature · 1 line
2.25.4