Skip to content

RFC rseq uapi and selftest updates

Mathieu Desnoyers linux-api linux-kselftest lkml 1 version Applied

Status from this message: The following commit has been merged into the sched/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest15 patches 8 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/15selftests/rseq: introduce own copy of rseq uapi headertools/testing/selftests/rseq/rseq-abi.h tools/testing/selftests/rseq/rseq.c tools/testing/selftests/rseq/rseq.h+161 -140 replies
2/15rseq: Remove broken uapi field layout on 32-bit little endianinclude/uapi/linux/rseq.h+4 -139 replies
3/15selftests/rseq: Remove useless assignment to cpu variabletools/testing/selftests/rseq/param_test.c+1 -30 replies
4/15selftests/rseq: Remove volatile from __rseq_abitools/testing/selftests/rseq/rseq.c tools/testing/selftests/rseq/rseq.h+4 -40 replies
5/15selftests/rseq: Introduce rseq_get_abi() helpertools/testing/selftests/rseq/rseq-arm.h tools/testing/selftests/rseq/rseq-arm64.h tools/testing/selftests/rseq/rseq-mips.h +4 more+99 -940 replies
6/15selftests/rseq: Introduce thread pointer getterstools/testing/selftests/rseq/rseq-generic-thread-pointer.h tools/testing/selftests/rseq/rseq-ppc-thread-pointer.h tools/testing/selftests/rseq/rseq-thread-pointer.h +1 more+114 -00 replies
7/15selftests/rseq: Uplift rseq selftests for compatibility with glibc-2.35tools/testing/selftests/rseq/Makefile tools/testing/selftests/rseq/rseq.c tools/testing/selftests/rseq/rseq.h+88 -880 replies
8/15selftests/rseq: Fix ppc32: wrong rseq_cs 32-bit field pointer on big endiantools/testing/selftests/rseq/rseq-arm.h tools/testing/selftests/rseq/rseq-arm64.h tools/testing/selftests/rseq/rseq-mips.h +2 more+38 -380 replies
9/15selftests/rseq: Fix ppc32 missing instruction selection "u" and "x" for load/storetools/testing/selftests/rseq/rseq-ppc.h+28 -270 replies
10/15selftests/rseq: Fix ppc32 offsets by using long rather than off_ttools/testing/selftests/rseq/basic_percpu_ops_test.c tools/testing/selftests/rseq/param_test.c tools/testing/selftests/rseq/rseq-arm.h +6 more+11 -110 replies
11/15selftests/rseq: Fix warnings about #if checks of undefined tokenstools/testing/selftests/rseq/param_test.c tools/testing/selftests/rseq/rseq-x86.h+2 -20 replies
12/15selftests/rseq: Remove arm/mips asm goto compiler work-aroundtools/testing/selftests/rseq/rseq-arm.h tools/testing/selftests/rseq/rseq-mips.h+0 -740 replies
13/15selftests/rseq: Fix: work-around asm goto compiler bugstools/testing/selftests/rseq/compiler.h tools/testing/selftests/rseq/rseq-arm.h tools/testing/selftests/rseq/rseq-arm64.h +4 more+245 -60 replies
14/15selftests/rseq: x86-64: use %fs segment selector for accessing rseq thread areatools/testing/selftests/rseq/rseq-x86.h+30 -280 replies
15/15selftests/rseq: x86-32: use %gs segment selector for accessing rseq thread areatools/testing/selftests/rseq/rseq-x86.h+34 -320 replies

Reviews trailers per patch

1 of 15 patches has a Reviewed-by or Acked-by.

PatchChristian Brauner
1/15
2/15A-b
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 00/15] rseq uapi and selftest updates

Update the rseq selftests to adapt to the userspace ABI chosen by glibc (will be released in February 2022). Provide a fallback implementation to work with older glibc as well.

Remove broken 32-bit little/big endian accessor fields in rseq uapi.

Integrate various fixes gathered from librseq, including work-around for known gcc and clang compiler bugs with asm goto.

The uplift to glibc's userspace ABI means we can now use %fs/%gs segment selectors directly in the inline assembler for accesses to the rseq thread area on x86.

Feedback is welcome,

Thanks,

Mathieu

Mathieu Desnoyers (15):
selftests/rseq: introduce own copy of rseq uapi header
rseq: Remove broken uapi field layout on 32-bit little endian selftests/rseq: Remove useless assignment to cpu variable selftests/rseq: Remove volatile from __rseq_abi selftests/rseq: Introduce rseq_get_abi() helper selftests/rseq: Introduce thread pointer getters selftests/rseq: Uplift rseq selftests for compatibility with

    glibc-2.35

selftests/rseq: Fix ppc32: wrong rseq_cs 32-bit field pointer on big
endian
selftests/rseq: Fix ppc32 missing instruction selection "u" and "x"
for load/store
selftests/rseq: Fix ppc32 offsets by using long rather than off_t selftests/rseq: Fix warnings about #if checks of undefined tokens selftests/rseq: Remove arm/mips asm goto compiler work-around selftests/rseq: Fix: work-around asm goto compiler bugs selftests/rseq: x86-64: use %fs segment selector for accessing rseq
thread area
selftests/rseq: x86-32: use %gs segment selector for accessing rseq
thread area

 include/uapi/linux/rseq.h                     |  17 +-
 tools/testing/selftests/rseq/Makefile         |   2 +-
 .../selftests/rseq/basic_percpu_ops_test.c    |   2 +-
 tools/testing/selftests/rseq/compiler.h       |  30 +++
 tools/testing/selftests/rseq/param_test.c     |   8 +-
 tools/testing/selftests/rseq/rseq-abi.h       | 151 +++++++++++++
 tools/testing/selftests/rseq/rseq-arm.h       | 110 +++++-----
 tools/testing/selftests/rseq/rseq-arm64.h     |  79 +++++--
 .../rseq/rseq-generic-thread-pointer.h        |  25 +++
 tools/testing/selftests/rseq/rseq-mips.h      |  71 ++-----
 .../selftests/rseq/rseq-ppc-thread-pointer.h  |  30 +++
 tools/testing/selftests/rseq/rseq-ppc.h       | 128 +++++++----
 tools/testing/selftests/rseq/rseq-s390.h      |  55 +++--
 tools/testing/selftests/rseq/rseq-skip.h      |   2 +-
 .../selftests/rseq/rseq-thread-pointer.h      |  19 ++
 .../selftests/rseq/rseq-x86-thread-pointer.h  |  40 ++++
 tools/testing/selftests/rseq/rseq-x86.h       | 200 ++++++++++++------
 tools/testing/selftests/rseq/rseq.c           | 163 +++++++-------
 tools/testing/selftests/rseq/rseq.h           |  29 ++-
 19 files changed, 793 insertions(+), 368 deletions(-)
 create mode 100644 tools/testing/selftests/rseq/compiler.h
 create mode 100644 tools/testing/selftests/rseq/rseq-abi.h
 create mode 100644 tools/testing/selftests/rseq/rseq-generic-thread-pointer.h
 create mode 100644 tools/testing/selftests/rseq/rseq-ppc-thread-pointer.h
 create mode 100644 tools/testing/selftests/rseq/rseq-thread-pointer.h
 create mode 100644 tools/testing/selftests/rseq/rseq-x86-thread-pointer.h
Signature · 1 line
2.17.1