Skip to content

cpu/hotplug: Keep cpu hotplug disabled until the rebooting cpu is stable

Pingfan Liu kexec linux-arm-kernel linux-ia64 linuxppc-dev lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 1 replyIn review
  2. v32 patches 5 repliesSuperseded
  3. v21 patch 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch4 repliesSuperseded

Changes in v4 from the cover letter

Fix the cpu hotplug enable before kexec-rebooting in powerpc. Improve commit log and the code's note.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2cpu/hotplug: Keep cpu hotplug disabled until the rebooting cpu is stablearch/powerpc/kexec/core_64.c kernel/cpu.c kernel/kexec_core.c+11 -110 replies
2/2cpu/hotplug: Remove the input parameter primary_cpu of smp_shutdown_nonboot_cpus()arch/arm/kernel/reboot.c arch/arm64/kernel/process.c arch/ia64/kernel/process.c +3 more+8 -81 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchCatalin Marinas
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCHv4 0/2] cpu/hotplug: Keep cpu hotplug disabled until the rebooting cpu is stable

For the architectures (arm/arm64/ia64/riscv), which relies on the cpu hot-removing mechanism to implement "kexec -e", it is important to ensure that the rebooting happens on a valid online cpu. And this logic should have been guaranteed in migrate_to_reboot_cpu().

But the current code has either contradict (resolved by [2/2]) or redundancy (resolved by [1/2]) about the logic.

V3 -> V4:
Fix the cpu hotplug enable before kexec-rebooting in powerpc. Improve commit log and the code's note.

V2 -> V3:
Taking in [2/2], which also has problem with the valid rebooting cpu. (I had sent three patches for different arches. But maybe it is better to collapse them into one and collect acks from different arches' maintainers )

Cc: Eric Biederman <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Vincent Donnefort <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: YueHaibing <[email protected]>
Cc: Baokun Li <[email protected]>
Cc: Randy Dunlap <[email protected]>
Cc: Valentin Schneider <[email protected]>
Cc: kexec at lists.infradead.org
Cc: Geert Uytterhoeven <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: Jens Axboe <[email protected]>
To: [email protected]
Cc: Russell King <[email protected]>
Cc: Guenter Roeck <[email protected]>

Pingfan Liu (2):
cpu/hotplug: Keep cpu hotplug disabled until the rebooting cpu is
stable
cpu/hotplug: Remove the input parameter primary_cpu of
smp_shutdown_nonboot_cpus()

 arch/arm/kernel/reboot.c          |  2 +-
 arch/arm64/kernel/process.c       |  2 +-
 arch/ia64/kernel/process.c        |  2 +-
 arch/powerpc/kexec/core_64.c      |  1 +
 arch/riscv/kernel/machine_kexec.c |  2 +-
 include/linux/cpu.h               |  4 ++--
 kernel/cpu.c                      | 14 +++++++-------
 kernel/kexec_core.c               | 11 +++++------
 8 files changed, 19 insertions(+), 19 deletions(-)
Signature · 1 line
2.31.1