dnsproxy: Add input validation checks
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | main: Use g_strdup for online_check_ipv{4,6}_url configsrc/ | +9 | 0 replies | |
| 2/5 | dnsproxy: Update TCP length headersrc/ | +3 | 0 replies | |
| 3/5 | dnsproxy: Validate input data before using themsrc/ | +26 | 0 replies | |
| 4/5 | dnsproxy: Avoid 100 % busy loop in TCP server casesrc/ | +12 | 0 replies | |
| 5/5 | dnsproxy: Keep timeout in TCP case even after connection is establishedsrc/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] dnsproxy: Add input validation checks
Matthias Gerstner was busy testing the dnsproxy code and found a bunch of bugs. With a lot of input and help from him we came up with the following patches.
dnsproxy.c is in a pretty bad shape and needs a complete rewrite with proper tests added. This will take time and brave soul to do so. Though things aren't that bad as there is the option to use systemd-resolved as DNS proxy. I haven't looked at the code of it but I am pretty sure it is way better than dnsproxy.c :)
Anyway, I'd like to thank Matthias for his excellent support and contributions fixing up these bugs.
Thanks,
Daniel
Daniel Wagner (2):
main: Use g_strdup for online_check_ipv{4,6}_url config
dnsproxy: Validate input data before using them
Matthias Gerstner (3):
dnsproxy: Update TCP length header
dnsproxy: Avoid 100 % busy loop in TCP server case
dnsproxy: Keep timeout in TCP case even after connection is
established
src/dnsproxy.c | 51 ++++++++++++++++++++++++++++++++++++++++---------- src/main.c | 11 +++++++++-- 2 files changed, 50 insertions(+), 12 deletions(-)
Signature · 1 line
2.34.1