sysfb: Fix memory-region management
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 4 repliesIn review
v2 from the cover letter
* fix possible NULL deref in simpledrm (Jocelyn)
* various style fixes (Javier)
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | fbdev: Hot-unplug firmware fb devices on forced removaldrivers/ include/ | +27 | 0 replies | |
| 2/5 | drivers/firmware: Don't mark as busy the simple-framebuffer IO resourcedrivers/ | +1 | 0 replies | |
| 3/5 | drm/simpledrm: Request memory region in driverdrivers/ | +17 | 1 reply | |
| 4/5 | fbdev/simplefb: Request memory region in driverdrivers/ | +45 | 1 reply | |
| 5/5 | drm: Add TODO item for requesting memory regionsDocumentation/ | +15 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Javier Martinez Canillas | Zack Rusin | Thomas Zimmermann | Jocelyn Falempe | Hans de Goede |
|---|---|---|---|---|---|
| Series | R-b | ||||
| 1/5 | R-b | R-b | |||
| 2/5 | R-b | R-b | |||
| 3/5 | R-b | R-b | |||
| 4/5 | R-b | ||||
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH 0/5] sysfb: Fix memory-region management
Request framebuffer memory in simpledrm and simplefb. Do a hot-unplug operation when removing fbdev firmware drivers.
After being unloaded by a hardware driver, simplefb leaves behind the firmware framebuffer's platform device. This prevents other drivers from acquiring the memory as reported at [1].
Patch 1 changes the removal code of remove_conflicting_framebuffers() to remove the underlying device and the rsp memory region.
Patches 2 to 4 update sysfb and its drivers. The sysfb code does no longer mark the framebuffer memory with IORESOURCE_BUSY. Instead, the device drivers acquire the memory when they probe the device.
Patch 5 adds a todo item to acquire memory regions in all DRM drivers.
Tested with simpledrm and simplefb.
[1] https://lore.kernel.org/dri-devel/[email protected]/
v2:
* fix possible NULL deref in simpledrm (Jocelyn)
* various style fixes (Javier)
Javier Martinez Canillas (1):
drivers/firmware: Don't mark as busy the simple-framebuffer IO
resource
Thomas Zimmermann (4):
fbdev: Hot-unplug firmware fb devices on forced removal drm/simpledrm: Request memory region in driver fbdev/simplefb: Request memory region in driver
drm: Add TODO item for requesting memory regions
Documentation/gpu/todo.rst | 15 +++++++ drivers/firmware/sysfb_simplefb.c | 2 +- drivers/gpu/drm/tiny/simpledrm.c | 22 ++++++++--- drivers/video/fbdev/core/fbmem.c | 29 ++++++++++++-- drivers/video/fbdev/simplefb.c | 65 +++++++++++++++++++++---------- include/linux/fb.h | 1 + 6 files changed, 105 insertions(+), 29 deletions(-)
base-commit: 0bb81b5d6db5f689b67f9d8b35323235c45e890f
prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: 8e52143a6cd7b8fb789e656208f6edde71d0f499
Signature · 1 line
2.34.1