Skip to content

platform/chrome: cros_ec: miscellaneous cleanups

Tzung-Bi Shih chrome-platform lkml 5 versions – Applied

Status from this message: This series was applied to chrome-platform/linux.git (for-kernelci)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 1 replyApplied 5/5
  2. v45 patches 3 repliesSuperseded
  3. v36 patches 6 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v26 patches12 repliesSuperseded
v16 patches0 repliesSuperseded

Changes in v5 from the cover letter

Patches in v5 All 5 applied

#Subject and filesSizeRepliesApplied
1/5platform/chrome: cros_ec: fix error handling in cros_ec_register()drivers/platform/chrome/cros_ec.c+10 -60 repliesApplied
2/5platform/chrome: cros_ec: remove unused variable `was_wake_device`drivers/platform/chrome/cros_ec.c include/linux/platform_data/cros_ec_proto.h+0 -40 repliesApplied
3/5platform/chrome: cros_ec: determine `wake_enabled` in cros_ec_suspend()drivers/platform/chrome/cros_ec.c+4 -31 replyApplied
4/5platform/chrome: cros_ec: sort header inclusion alphabeticallydrivers/platform/chrome/cros_ec.c+2 -20 repliesApplied
5/5platform/chrome: cros_ec: append newline to all logsdrivers/platform/chrome/cros_ec.c+4 -40 repliesApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchPrashant MalaniGuenter Roeck
1/5R-b
2/5R-b
3/5R-b
4/5R-b R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/5] platform/chrome: cros_ec: miscellaneous cleanups

The 1st patch fixes unhandled undos in error handling path.

The rest of patches cleans drivers/platform/chrome/cros_ec.c.

Changes from v4:
(https://patchwork.kernel.org/project/chrome-platform/cover/[email protected]/)
- Rollback the 3rd patch to older version.

Changes from v3:
(https://patchwork.kernel.org/project/chrome-platform/cover/[email protected]/)
- Drop "platform/chrome: cros_ec: don't initialize err in cros_ec_register()".
- Rename the 3rd patch's title.

Changes from v2:
(https://patchwork.kernel.org/project/chrome-platform/cover/[email protected]/)
- Fix review comments in 1st and 2nd patch.

Changes from v1:
(https://lore.kernel.org/lkml/[email protected]/T/#u)
- Use imperative mood in commit messages.
- Use IS_ERR_OR_NULL() in 1st patch.

Tzung-Bi Shih (5):
platform/chrome: cros_ec: fix error handling in cros_ec_register() platform/chrome: cros_ec: remove unused variable was_wake_device platform/chrome: cros_ec: determine wake_enabled in
cros_ec_suspend()
platform/chrome: cros_ec: sort header inclusion alphabetically platform/chrome: cros_ec: append newline to all logs

 drivers/platform/chrome/cros_ec.c           | 36 ++++++++++++---------
 include/linux/platform_data/cros_ec_proto.h |  3 --
 2 files changed, 20 insertions(+), 19 deletions(-)
Signature · 1 line
2.35.1.265.g69c8d7142f-goog