Skip to content

ARM: ftrace fixes and cleanups

Ard Biesheuvel linux-arm-kernel 3 versions – Applied

Status from this message: Applied to sudeep.holla/linux (for-next/scmi), thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest13 patches 13 repliesApplied
  2. v212 patches 12 repliesSuperseded
  3. v18 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- simplify kprobes patch and avoid global FPREG_ macros
- update cacheflush code to avoid R7 and R11 entirely, instead of preserving/restoring them
- add new patch to disable ftrace in Broadcom Kona SMC code
- add acks from various folks (thanks!)

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/13ARM: ftrace: ensure that ADR takes the Thumb bit into accountarch/arm/kernel/entry-ftrace.S+1 -10 replies
2/13ARM: ftrace: use ADD not POP to counter PUSH at entryarch/arm/kernel/entry-ftrace.S arch/arm/kernel/ftrace.c+14 -30 replies
3/13ARM: ftrace: use trampolines to keep .init.text in branching rangearch/arm/kernel/entry-ftrace.S arch/arm/kernel/ftrace.c+36 -30 replies
4/13ARM: ftrace: avoid redundant loads or clobbering IParch/arm/kernel/entry-ftrace.S+22 -290 replies
5/13ARM: ftrace: avoid unnecessary literal loadsarch/arm/kernel/entry-ftrace.S+11 -160 replies
6/13ARM: ftrace: enable HAVE_FUNCTION_GRAPH_FP_TESTarch/arm/include/asm/ftrace.h arch/arm/kernel/entry-ftrace.S arch/arm/kernel/ftrace.c+8 -10 replies
7/13ARM: unwind: track location of LR value in stack framearch/arm/include/asm/stacktrace.h arch/arm/kernel/Makefile arch/arm/kernel/unwind.c+8 -31 reply
8/13ARM: ftrace: enable the graph tracer with the EABI unwinderarch/arm/Kconfig arch/arm/Kconfig.debug arch/arm/include/asm/ftrace.h +3 more+40 -344 replies
9/13ARM: kprobes: treat R7 as the frame pointer register in Thumb2 buildsarch/arm/probes/kprobes/actions-common.c arch/arm/probes/kprobes/actions-thumb.c+17 -70 replies
10/13drivers/firmware/scmi: disable ftrace for Clang Thumb2 buildsdrivers/firmware/arm_scmi/Makefile+7 -03 replies
11/13ARM: cacheflush: avoid clobbering the frame pointerarch/arm/include/asm/cacheflush.h arch/arm/mach-exynos/mcpm-exynos.c arch/arm/mm/cache-v7.S+23 -354 replies
12/13ARM: mach-bcm: disable ftrace in SMC invocation routinesarch/arm/mach-bcm/Makefile+1 -01 reply
13/13Revert "ARM: 9144/1: forbid ftrace with clang and thumb2_kernel"arch/arm/Kconfig+1 -10 replies

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchNick DesaulniersSteven Rostedt (Google)Linus WalleijMasami HiramatsuSudeep Holla
1/13R-b R-b R-b
2/13R-b R-b R-b
3/13R-b R-b R-b
4/13R-b
5/13R-b R-b
6/13R-b
7/13R-b
8/13R-b
9/13R-b
10/13R-b A-b
11/13R-b
12/13A-b
13/13R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/13] ARM: ftrace fixes and cleanups

This series addresses a number of issues in the ARM support code for ftrace, mostly related to Thumb2 but affecting other configurations as well.

Changes since v2:
- simplify kprobes patch and avoid global FPREG_ macros
- update cacheflush code to avoid R7 and R11 entirely, instead of preserving/restoring them
- add new patch to disable ftrace in Broadcom Kona SMC code
- add acks from various folks (thanks!)

Changes since v1:
- add a couple of patches to enable ftrace in Thumb2 mode when building with Clang, which was the one remaining unsupported configuration
- fix up some minor code issues caught by the bots
- add some acks

Cc Steven Rostedt <[email protected]>
Cc Sudeep Holla <[email protected]>
Cc Cristian Marussi <[email protected]>
Cc Nathan Chancellor <[email protected]>
Cc Nick Desaulniers <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Masami Hiramatsu <[email protected]>

Ard Biesheuvel (13):
ARM: ftrace: ensure that ADR takes the Thumb bit into account
ARM: ftrace: use ADD not POP to counter PUSH at entry
ARM: ftrace: use trampolines to keep .init.text in branching range
ARM: ftrace: avoid redundant loads or clobbering IP
ARM: ftrace: avoid unnecessary literal loads
ARM: ftrace: enable HAVE_FUNCTION_GRAPH_FP_TEST
ARM: unwind: track location of LR value in stack frame
ARM: ftrace: enable the graph tracer with the EABI unwinder
ARM: kprobes: treat R7 as the frame pointer register in Thumb2 builds drivers/firmware/scmi: disable ftrace for Clang Thumb2 builds
ARM: cacheflush: avoid clobbering the frame pointer
ARM: mach-bcm: disable ftrace in SMC invocation routines Revert "ARM: 9144/1: forbid ftrace with clang and thumb2_kernel"

 arch/arm/Kconfig                         |   4 +-
 arch/arm/Kconfig.debug                   |   2 +-
 arch/arm/include/asm/cacheflush.h        |  12 +-
 arch/arm/include/asm/ftrace.h            |  20 +--
 arch/arm/include/asm/stacktrace.h        |   3 +
 arch/arm/kernel/Makefile                 |   6 +-
 arch/arm/kernel/entry-ftrace.S           | 128 +++++++++++---------
 arch/arm/kernel/ftrace.c                 |  62 ++++++++--
 arch/arm/kernel/unwind.c                 |   7 +-
 arch/arm/mach-bcm/Makefile               |   1 +
 arch/arm/mach-exynos/mcpm-exynos.c       |   6 +-
 arch/arm/mm/cache-v7.S                   |  40 +++---
 arch/arm/probes/kprobes/actions-common.c |   8 +-
 arch/arm/probes/kprobes/actions-thumb.c  |  16 ++-
 drivers/firmware/arm_scmi/Makefile       |   7 ++
 15 files changed, 189 insertions(+), 133 deletions(-)
Signature · 7 lines
2.30.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel