Skip to content

x86: MSR_SPEC_CTRL support for SVM guests

Andrew Cooper xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 17 repliesIn review
  2. v18 patches 19 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9x86/cpuid: Advertise SSB_NO to guests by defaultxen/include/public/arch-x86/cpufeatureset.h+1 -14 replies
2/9x86/spec-ctrl: Drop use_spec_ctrl booleanxen/arch/x86/spec_ctrl.c+8 -60 replies
3/9x86/spec-ctrl: Introduce new has_spec_ctrl booleanxen/arch/x86/spec_ctrl.c+11 -110 replies
4/9x86/spec-ctrl: Don't use spec_ctrl_{enter,exit}_idle() for S3xen/arch/x86/acpi/power.c+3 -24 replies
5/9x86/spec-ctrl: Record the last write to MSR_SPEC_CTRLxen/arch/x86/acpi/power.c xen/arch/x86/include/asm/current.h xen/arch/x86/include/asm/spec_ctrl_asm.h +3 more+24 -52 replies
6/9x86/spec-ctrl: Use common MSR_SPEC_CTRL logic for AMDxen/arch/x86/acpi/power.c xen/arch/x86/cpu/amd.c xen/arch/x86/include/asm/hvm/svm/svm.h +2 more+30 -51 reply
7/9x86/svm: VMEntry/Exit logic for MSR_SPEC_CTRLxen/arch/x86/hvm/svm/entry.S xen/arch/x86/hvm/svm/svm.c xen/arch/x86/include/asm/msr.h +1 more+46 -59 replies
8/9x86/msr: AMD MSR_SPEC_CTRL infrastructurexen/arch/x86/hvm/svm/svm.c xen/arch/x86/msr.c+14 -30 replies
9/9x86/cpuid: Enable MSR_SPEC_CTRL in SVM guests by defaultxen/arch/x86/cpuid.c xen/arch/x86/hvm/svm/svm.c xen/include/public/arch-x86/cpufeatureset.h +1 more+33 -172 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchJan Beulich
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] x86: MSR_SPEC_CTRL support for SVM guests

Fixes/extensions to allow HVM guests to use AMD hardware MSR_SPEC_CTRL facilities.

No PV support yet - that will require some substantially more careful unpicking of the PV entry/exit asm.

Andrew Cooper (9):
x86/cpuid: Advertise SSB_NO to guests by default x86/spec-ctrl: Drop use_spec_ctrl boolean x86/spec-ctrl: Introduce new has_spec_ctrl boolean x86/spec-ctrl: Don't use spec_ctrl_{enter,exit}_idle() for S3 x86/spec-ctrl: Record the last write to MSR_SPEC_CTRL x86/spec-ctrl: Use common MSR_SPEC_CTRL logic for AMD x86/svm: VMEntry/Exit logic for MSR_SPEC_CTRL x86/msr: AMD MSR_SPEC_CTRL infrastructure x86/cpuid: Enable MSR_SPEC_CTRL in SVM guests by default

 xen/arch/x86/acpi/power.c                   |  8 +++-
 xen/arch/x86/cpu/amd.c                      |  2 +-
 xen/arch/x86/cpuid.c                        | 16 +++++--
 xen/arch/x86/hvm/svm/entry.S                | 12 +++---
 xen/arch/x86/hvm/svm/svm.c                  | 40 +++++++++++++++++
 xen/arch/x86/include/asm/current.h          |  2 +-
 xen/arch/x86/include/asm/hvm/svm/svm.h      |  3 ++
 xen/arch/x86/include/asm/msr.h              |  9 ++++
 xen/arch/x86/include/asm/spec_ctrl_asm.h    |  7 +++
 xen/arch/x86/msr.c                          |  8 ++--
 xen/arch/x86/setup.c                        |  5 ++-
 xen/arch/x86/smpboot.c                      |  7 ++-
 xen/arch/x86/spec_ctrl.c                    | 66 ++++++++++++++++++++---------
 xen/include/public/arch-x86/cpufeatureset.h | 18 ++++----
 xen/tools/gen-cpuid.py                      | 14 +++---
 15 files changed, 166 insertions(+), 51 deletions(-)
Signature · 1 line
2.11.0